Repository navigation
fix(dial): verify HTTP/1.x protocol in verifyServerResponseH1 - #550
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/http2
branch
from
December 16, 2025 19:01
ea8732a to
00fa373
Compare
code-asher
approved these changes
Dec 17, 2025
Member
Author
|
Thanks for reviewing! Oh, looks like I failed to rebase properly, the protocol rename was supposed to be just in the other PR. 😄 |
Add resp.ProtoMajor check in verifyServerResponseH1 for consistency with verifyServerResponseH2 which already performs this check. Refs #539
mafredri
force-pushed
the
mafredri/verify-proto-major
branch
from
December 17, 2025 18:59
06013d3 to
ced6e9e
Compare
mafredri
added a commit
that referenced
this pull request
Oct 29, 2026
Add resp.ProtoMajor check in verifyServerResponseH1 for consistency with verifyServerResponseH2 which already performs this check. Refs #539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resp.ProtoMajor check in verifyServerResponseH1 for consistency
with verifyServerResponseH2 which already performs this check.
Refs #539