Skip to content

chore: use oidc to publish to vs code marketplace #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 5 commits into from
Oct 28, 2026
Merged

chore: use oidc to publish to vs code marketplace #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
396dae0
chore: use oidc to publish to vs code marketplace
code-asher Oct 28, 2026
cd33060
Remove tokens step entirely
code-asher Oct 28, 2026
30ba268
Skip publish steps on forks
code-asher Oct 28, 2026
031b1ca
Bump @vscode/vsce to 4.1.0
code-asher Oct 28, 2026
8288e95
Comment on what id-token is for
code-asher Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 7 additions & 25 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,32 +68,15 @@ jobs:
path: ${{ steps.package.outputs.vsix }}
if-no-files-found: error

# Job-level `if` can't read secrets, and the package job runs dependency
# code, so a separate job reports which marketplace tokens are set.
tokens:
name: Check Marketplace Tokens
runs-on: ubuntu-24.04
timeout-minutes: 5
outputs:
vsce: ${{ steps.check.outputs.vsce }}
ovsx: ${{ steps.check.outputs.ovsx }}
steps:
- name: Check which tokens are set
id: check
env:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
OVSX_PAT: ${{ secrets.OVSX_PAT }}
run: |
echo "vsce=$([ -n "$VSCE_PAT" ] && echo true || echo false)" >> "$GITHUB_OUTPUT"
echo "ovsx=$([ -n "$OVSX_PAT" ] && echo true || echo false)" >> "$GITHUB_OUTPUT"

publish-vscode:
name: Publish to VS Marketplace
needs: [package, tokens]
if: needs.tokens.outputs.vsce == 'true'
needs: package
Comment thread
code-asher marked this conversation as resolved.
if: github.repository == 'coder/vscode-coder'
runs-on: ubuntu-24.04
timeout-minutes: 10
environment: publish
permissions:
id-token: write # Allows generating an OIDC token.
steps:
- name: Setup Node.js
uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
Expand All @@ -118,14 +101,13 @@ jobs:

- name: Publish to VS Marketplace
env:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
VSIX: ${{ needs.package.outputs.vsix }}
run: vsce publish $PRE_RELEASE_FLAG --packagePath "$VSIX"
run: vsce publish $PRE_RELEASE_FLAG --packagePath "$VSIX" --oidc

publish-ovsx:
name: Publish to Open VSX
needs: [package, tokens]
if: needs.tokens.outputs.ovsx == 'true'
needs: package
if: github.repository == 'coder/vscode-coder'
runs-on: ubuntu-24.04
timeout-minutes: 10
environment: publish
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@
"@vscode/codicons": "catalog:",
"@vscode/test-cli": "^0.0.15",
"@vscode/test-electron": "^3.1.0",
"@vscode/vsce": "^4.0.0",
"@vscode/vsce": "^4.1.0",
"babel-plugin-react-compiler": "catalog:",
"bufferutil": "^4.1.0",
"coder": "link:vendor/coder",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading