Skip to content

feat(codex): support user-managed configuration - #1208

Merged
Edd88-pixel merged 4 commits into
coder:mainfrom
b00ste:codex/preserve-existing-codex-config
Oct 30, 2026
Merged

Edd88-pixel merged 4 commits into
coder:mainfrom
b00ste:codex/preserve-existing-codex-config

Conversation

@b00ste

@b00ste b00ste commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Persistent workspaces can already contain user-owned Codex provider and authentication settings. The current module writes a fresh config.toml on its first run even with install_codex = false. Add manage_config = false so those workspaces can use the module without creating or modifying their configuration.

The default remains true. Configuration-related inputs (MCP, custom TOML, reasoning effort, and AI Gateway) are rejected when management is disabled. Installation and explicitly configured API-key authentication retain their existing behavior. Examples advance to 5.5.0.

Validation: terraform validate; all 20 module Terraform tests passed with Terraform 1.15.8; TypeScript typecheck; bun run fmt; shell smoke check of the disabled configuration path. Added container regressions for preserving an existing configuration across repeated runs and leaving an absent config directory absent. Docker-backed integration tests were not run because the validation workspace has no Docker daemon.

Assisted by OpenAI Codex (GPT-6).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-25T08:51:07.087116Z
We couldn’t complete this review. Comment @codex review to try again.
62cdaee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Edd88-pixel Edd88-pixel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good. Thanks!

@Edd88-pixel Edd88-pixel added the version:minor Add to PRs requiring a minor version upgrade label Oct 30, 2026 — with ChatGPT Codex Connector
@Edd88-pixel
Edd88-pixel enabled auto-merge (squash) October 30, 2026 09:40
@Edd88-pixel

Copy link
Copy Markdown
Collaborator

@b00ste Could you update your branch with the latest main?

@Edd88-pixel
Edd88-pixel merged commit 8a50550 into coder:main Oct 30, 2026
5 checks passed
@b00ste
b00ste deleted the codex/preserve-existing-codex-config branch October 30, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor Add to PRs requiring a minor version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants