You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
verify-libghostty-vt-node skill: three deferred script fixes from PR 25 review #27
Follow-up from the review of #25 (the verify-libghostty-vt-node agent skill). Codex review round 4 on head 676de35 reported three P2 findings. I deferred them under the review cap: they affect only agents that run the skill, not package users.
scripts/launch.sh rebuilds libghostty-vt even when the caller supplies a prebuilt library through LIBGHOSTTY_VT_PREFIX, or through LIBGHOSTTY_VT_INCLUDE_DIR plus LIBGHOSTTY_VT_STATIC_LIB. It must use the supplied artifacts, or refuse these variables with a clear message. Review thread: chore: add the verify-libghostty-vt-node driving skill #25 (comment)
Findings in launch.sh came in four rounds (6, then 1, then 6, then 3). Before another hardening round, consider simplifying it. One way is to support only the managed libghostty-vt build and the default mktemp RUN_ROOT.
Done when: all three behaviors are fixed, the skill's 18 journeys still pass, and doctor.sh fails on a swapped addon file.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
Activity
Merge pull request #25: add the verify-libghostty-vt-node driving skill