Repository navigation
🤖 fix: bump Go to 1.26.10 and go-jose to v4.1.6 - #393
Merged
Merged
Conversation
Clears GO-2026-6809 (crypto/x509, reached from servingcert.Bundle.NeedsRenewal), which fails govulncheck in the required lint job, and CVE-2026-116587 (go-jose v4.1.4), which fails the Trivy filesystem and image scans. _Generated with `mux` • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Id95ac0e64470190ff76d2cde9e06d702ebfa9622 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Member
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Go toolchain from 1.26.9 to 1.26.10 and
github.com/go-jose/go-jose/v4from v4.1.4 to v4.1.6. This clears the new findings that make every merge-queue run fail since the vulnerability database updates after 2026-10-15.Background
The merge-group run of #391 (run 40940296865) failed three checks on findings in
main's dependencies:lint: govulncheck reports GO-2026-6809 incrypto/x509@go1.26.9, which the code reaches fromservingcert.Bundle.NeedsRenewal(internal/aggregated/servingcert/servingcert.go:277). Go 1.26.10 fixes it.Trivy filesystem scanandTrivy image scan: CVE-2026-116587 (HIGH) in go-jose v4.1.4, an indirect dependency. v4.1.6 fixes it.mainlast ran CI green on 2026-10-15, somainitself fails these checks now, and no PR can pass the queue until this lands. This follows the pattern of #222.Implementation
go.mod:go 1.26.10, go-jose v4.1.6 (go get,go mod tidy,go mod vendor). No other module moved.AGENTS.md,CONTRIBUTING.md,README.md: the Go version mentions.Validation
With Go 1.26.10:
GOFLAGS=-mod=vendor go tool govulncheck ./...reports no called vulnerabilities.trivy fs --skip-dirs vendor --severity HIGH,CRITICALon the tree, andtrivy rootfson aCGO_ENABLED=0build of the binary. Both report 0 findings.Risks
Low. This is a toolchain patch release plus a patch bump of an indirect dependency. The GoReleaser release path was not dry-run locally. It reads the Go version from
go.modthrough setup-go, as before.Generated with
mux• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$17.93