Skip to content

refactor: write the top-level and Encryption commands through $this->getOutput() - #10688

Merged
paulbalandan merged 1 commit into
codeigniter4:4.8from
paulbalandan:top-level-encryption-commands-output
Oct 30, 2026
Merged

paulbalandan merged 1 commit into
codeigniter4:4.8from
paulbalandan:top-level-encryption-commands-output

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Next batch of the command migration. help, list, key:generate and key:rotate now write through $this->getOutput(), and the confirmations of the two key commands ask through $this->getPrompt(), so a Prompt override reaches them.

  • list wraps its descriptions with Output::wrap().
  • The private methods that write take the output from their caller.
  • key:generate no longer prints a blank line after its success message.

There are no other output changes, and the existing tests pass unchanged.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added 4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code labels Oct 30, 2026
@paulbalandan
paulbalandan merged commit 62a2ebe into codeigniter4:4.8 Oct 30, 2026
60 checks passed
@paulbalandan
paulbalandan deleted the top-level-encryption-commands-output branch October 30, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants