Skip to content

Fix score precision rounding (Issue #1734) - #1737

Open
pxsit wants to merge 1 commit into
cms-dev:mainfrom
pxsit:issue-fix
Open

pxsit wants to merge 1 commit into
cms-dev:mainfrom
pxsit:issue-fix

Conversation

@pxsit

@pxsit pxsit commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Round aggregate, public, and maximum scores to the configured precision so floating-point accumulation errors do not cause score comparisons to differ.

Closes #1734

Round aggregate, public, and maximum scores to the configured precision so floating-point accumulation errors do not cause score comparisons to differ.
Copilot AI balanced review requested due to automatic review settings November 1, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.85%. Comparing base (55ebd3a) to head (587221e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files         344      344           
  Lines       28360    28365    +5     
=======================================
+ Hits        16123    16127    +4     
- Misses      12237    12238    +1     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Score rounding only rounds actual score but not full score

2 participants