Skip to content

docs(expo): fix two identifier claims and list unmapped flows in the verify skill - #10779

Open
mikepitre wants to merge 1 commit into
mainfrom
mike/stoic-feynman-sgafnp
Open

mikepitre wants to merge 1 commit into
mainfrom
mike/stoic-feynman-sgafnp

Conversation

@mikepitre

@mikepitre mikepitre commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

A maintenance pass over the verify-clerk-expo skill read every feature page against the source and drove every committed spec on an iOS simulator. It fixes two claims that the code contradicts and names flows that the map left out:

  • user-button-and-profile.md said that profile rows have no stable identifier on Android. The clerk-android release that packages/expo-native-components/android/build.gradle pins sets clerk.userProfile.row.* as resource ids under UserProfileView (ClerkTestTags.kt, UserProfileView.kt clerkTestTagsAsResourceIds()), as features/README.md already said. The page now says that the ids exist and that the specs still find the rows by text.
  • SKILL.md said the test app's screens other than the home have verify.* testIDs. The Native modules screen uses unprefixed testIDs (google-sign-in-button, biometric-availability-button, and their results), as native-modules.md says. SKILL.md now names that exception.
  • The "Not mapped yet" list in features/README.md now names flows that no spec drives and the map never mentioned: sign-up and phone sign-in through the native AuthView, the native profile's flows past the email under Manage account (email, phone, and connected accounts, the Security screens, Add account, and Switch account), an inline UserProfileView that can be dismissed with onDismiss, useLocalCredentials, and the experimental resource cache.

The PR changes only Markdown under .claude/skills/verify-clerk-expo/, plus an empty changeset. A run of every spec on the iOS simulator exercised every feature. The screenshot below is the native profile that the UserButton opens, from that run.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:


Generated by Claude Code

Verified on an iOS simulator, as reported by the session that mikepitre started. Run r20261112-141633-4f02 on iPhone 17 Pro on macos-26 at 4ef6c75e2cc5, 20 of 20 passed.

user-button-profile
user-button-profile

…verify skill

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WtSUstmZ7Gn1gamdyBSf7z
@vercel

vercel Bot commented Nov 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 12, 2026 2:29pm UTC
swingset Ready Ready Preview Nov 12, 2026 2:29pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes update Expo verification documentation. They describe the Native modules screen’s testID exception, list additional unmapped native flows, and document Android profile-row identifiers. An empty Changeset file is also added.

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related PRs

  • clerk/javascript#10417: Documents the same Android native-view identifier behavior and text-based locator choice.

Suggested reviewers: seanperez29, wobsoriano

Merge Risk: Minimal · up to 4ef6c

This PR updates internal Expo verification notes and adds an empty changeset. It has no production behavior impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the docs change to the verify-clerk-expo skill, and the changeset corrects two identifier claims and lists unmapped flows. The title matches the main changes in the changeset, though i…
Description check Passed The description says the PR fixes two identifier claims in the verify-clerk-expo skill docs and lists unmapped flows. These points match the raw summary of changes to user-button-and-profile.md, SKILL…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the docs change to the verify-clerk-expo skill, and the changeset corrects two identifier claims and lists unmapped flows. The title matches the main changes in the changeset, though it does not mention the Native modules testID exception. The title uses the conventional commit format, and it is 81 characters long, which is slightly long but readable.

Full details: Description check

Explanation

The description says the PR fixes two identifier claims in the verify-clerk-expo skill docs and lists unmapped flows. These points match the raw summary of changes to user-button-and-profile.md, SKILL.md, and features/README.md. It also describes the iOS verification run, which is related context.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: clerk/javascript
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: c9bdae3
  • Layers: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 0f076620-cba7-4531-bb4a-fe1f68e425bf
Commits

Reviewing files that changed from the base of the PR and between c9bdae3 and 4ef6c75.

Files selected for processing: 4

  • .changeset/verify-expo-map-unmapped-flows.md
  • .claude/skills/verify-clerk-expo/SKILL.md
  • .claude/skills/verify-clerk-expo/features/README.md
  • .claude/skills/verify-clerk-expo/features/user-button-and-profile.md
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4ef6c75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikepitre
mikepitre marked this pull request as ready for review November 12, 2026 14:31
@mikepitre
mikepitre requested a review from a team November 12, 2026 14:31
@mikepitre
mikepitre enabled auto-merge (squash) November 12, 2026 14:31

Copy link
Copy Markdown
Contributor Author

Formatting | Dedupe | Changeset fails here on pnpm dedupe --check (ERR_PNPM_DEDUPE_CHECK_ISSUES). The check wants packages/msw to use next@16.4.6 and its @next/* packages in place of next@16.4.5. This PR changes no package.json and not the lockfile, only Markdown under .claude/skills/verify-clerk-expo/ and an empty changeset. The unrelated #10769 fails the same check with the same next@16.4.6 diff (14:17 UTC today), so the lockfile on main is no longer deduped against the registry. The fix is pnpm dedupe on main, in its own PR. I have not pushed it here, to keep this PR docs-only. Auto-merge stays queued and will merge once the check passes.


Generated by Claude Code

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10779

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10779

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10779

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10779

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10779

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10779

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10779

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10779

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10779

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10779

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10779

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10779

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10779

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10779

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10779

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10779

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10779

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10779

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10779

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10779

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10779

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10779

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10779

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10779

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10779

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10779

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10779

commit: 4ef6c75

This branch was successfully deployed

2 active deployments
Preview – swingset — 4ef6c75e Deployed Nov 12, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 4ef6c75e Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants