You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(expo): list each video's marked parts in a published hand-off - #10778
clerk/internal-mobile-e2e#19 has attach --video list the parts a run marked with host.evidence under the video's table, so a reviewer, and CodeRabbit, which can't watch a video, can tell which states each video shows. It adds those lists to the hand-off manifest as version 3.
Publisher:scripts/verify-attach.mjs reads version 3, with parts and before.parts, and still reads version 2 as having no parts. It writes the same lists as the package: "The video shows these parts, in order:", "Each video shows…" when both runs marked the same parts, or a before list and an after list otherwise. Parts are at most 20, each one line of at most 200 characters without <, >, a backtick or |.
Docs: the verify-clerk-expo skill's Evidence section describes the lists.
verify-attach.yml runs on workflow_run, so it uses the publisher from main. This has to merge before integration/expo-native pins a commit that includes #19, or a remote attach --video would hand off a version 3 manifest that main refuses. The pin bump will be its own PR.
Testing:
pnpm vitest run --root scripts verify-attach: 205 pass. New tests cover reading version 2 with and without a before, refusing malformed parts, and the layouts with and without a before, including separate before and after lists.
Not run against a real pull request or on a device.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
The hand-off manifest gets parts and before.parts lists as version 3. The workflow publishes them as numbered lists under the video's table, as attach does on a machine whose gh can attach. Version 2 manifests, which sessions on older commits still write, are read as having no parts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
Manifest version 3 adds ordered video-part labels with validation limits. Version 2 manifests remain accepted and default missing parts to empty lists. Uploaded evidence now describes video parts, using a shared description for matching before and after lists and separate descriptions when they differ. Tests cover parsing, validation, compatibility, and publication output.
The change adds marked-part lists to published video evidence and keeps older manifests readable. No merge-blocking risk was identified; the change has not been tried against a real pull request or on a device.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the Expo verification publisher now lists each video's marked parts in the published hand-off. It matches the changeset, which adds version 3 manifest parts metadata a…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description is specific and relevant. It explains that attach --video will list the video's marked parts, that the publisher in scripts/verify-attach.mjs reads manifest version 3 and still accep…
Full details: Title check
Explanation
The title names the main change: the Expo verification publisher now lists each video's marked parts in the published hand-off. It matches the changeset, which adds version 3 manifest parts metadata and renders part lists under each video. The 'test(expo)' prefix is a conventional-commit type that slightly misdescribes a publisher and docs change, but the subject still matches the primary change.
Full details: Description check
Explanation
The description is specific and relevant. It explains that attach --video will list the video's marked parts, that the publisher in scripts/verify-attach.mjs reads manifest version 3 and still accepts version 2, and that the verify-clerk-expo skill's Evidence section is updated. It also gives limits (20 parts, 200 characters, forbidden characters), a merge-order constraint with integration/expo-native, and the test results (205 passing tests). This matches the changeset summary.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.
Before, the version 3 hand-off was refused and nothing published; after, the block lists the three parts under the video's table.
Merge-base
This PR 853dd648
Also checked · 3 match
Before/after part lists Version 2 hand-offs still publish Malformed parts refused
Proof on 853dd648 · mocked: GitHub API (Publishing edits a real PR description; a fake gh on PATH holds the PR JSON and...) · Did Proof get it right? Yes · No
Deferred while we evaluate whether the review-rule fixes (clerk/clerk-ios#839, clerk/clerk-android#1267) resolve the unnecessary evidence requests. Revisit compact captions only if the problem persists.
Closing. The evidence rules in clerk/clerk-ios#839 and clerk/clerk-android#1267 fixed the CodeRabbit loop this was meant to help with. On clerk/clerk-ios#833, #834 and #835, every remaining ask was for a state that no video showed, and CodeRabbit read the hand-written part lists correctly. The captions would only save writing that list on PRs whose video shows several states, which does not justify longer descriptions. The branch stays on GitHub, so this can be reopened if CodeRabbit starts missing states a video shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
clerk/internal-mobile-e2e#19 has
attach --videolist the parts a run marked withhost.evidenceunder the video's table, so a reviewer, and CodeRabbit, which can't watch a video, can tell which states each video shows. It adds those lists to the hand-off manifest as version 3.scripts/verify-attach.mjsreads version 3, withpartsandbefore.parts, and still reads version 2 as having no parts. It writes the same lists as the package: "The video shows these parts, in order:", "Each video shows…" when both runs marked the same parts, or a before list and an after list otherwise. Parts are at most 20, each one line of at most 200 characters without<,>, a backtick or|.verify-attach.ymlruns onworkflow_run, so it uses the publisher frommain. This has to merge beforeintegration/expo-nativepins a commit that includes #19, or a remoteattach --videowould hand off a version 3 manifest thatmainrefuses. The pin bump will be its own PR.Testing:
pnpm vitest run --root scripts verify-attach: 205 pass. New tests cover reading version 2 with and without a before, refusing malformed parts, and the layouts with and without a before, including separate before and after lists.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code