Skip to content

docs(expo): say that AuthView also takes onHostBack in the verify skill - #10768

Merged
mikepitre merged 1 commit into
mainfrom
mike/stoic-feynman-th2tp0
Nov 11, 2026
Merged

mikepitre merged 1 commit into
mainfrom
mike/stoic-feynman-th2tp0

Conversation

@mikepitre

@mikepitre mikepitre commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

A maintenance pass over the verify-clerk-expo skill read every feature page against the source. It also drove every committed spec on an iOS simulator. The pass found one claim that the code contradicts, and it fixed it:

  • user-button-and-profile.md said that onHostBack is a prop "which only an inline UserProfileView has". AuthView takes it too: packages/expo-native-components/src/AuthView.tsx reads onHostBack and passes hostBackButton to the native view. EmbeddedNavigation.types.ts names both components. The page now says that the test app passes onHostBack only to its inline UserProfileView.
  • The "Not mapped yet" list in features/README.md now names AuthView's onHostBack and logoMaxHeight, which the test app passes to no AuthView.

The PR changes only Markdown under .claude/skills/verify-clerk-expo/, plus an empty changeset. A run of every spec on the iOS simulator passed 20 of 20, including user-button-and-profile/embedded-profile, which drives onHostBack. The screenshot below is from that run.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Generated by Claude Code

Verified on an iOS simulator, as reported by the session that mikepitre started. Run r20261111-124614-ad4f on iPhone 17 Pro on macos-26 at e635dff42c83, 20 of 20 passed.

embedded-profile
embedded-profile

@mikepitre
mikepitre requested a review from a team November 11, 2026 12:59
@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 11, 2026 12:59pm UTC
swingset Ready Ready Preview Nov 11, 2026 12:59pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e635dff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The verification map now lists AuthView’s onHostBack and logoMaxHeight as props that the test app does not pass. The UserButton and profile guide no longer limits onHostBack to inline UserProfileView and directs readers to embeddedProfile. An empty Changeset file was added.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • clerk/javascript#10524: Documents related UserProfileView behavior and identifies embeddedProfile as the test-app path for onHostBack.

Suggested reviewers: seanperez29

Merge Risk: Minimal · up to e635d

This is a documentation-only update to the Expo verification guidance with no runtime impact, so merge risk is minimal.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main documentation change: clarifying that Expo AuthView accepts onHostBack in the verify skill.
Description check Passed The description directly explains the documentation updates, the affected files, and the verification results. It is related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: clerk/javascript
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 4026619
  • Layers: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: d3cdfee0-07f9-4ab0-a956-8308e4028dd3
Commits

Reviewing files that changed from the base of the PR and between 4026619 and e635dff.

Files selected for processing: 3

  • .changeset/verify-expo-auth-view-host-back.md
  • .claude/skills/verify-clerk-expo/features/README.md
  • .claude/skills/verify-clerk-expo/features/user-button-and-profile.md
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 6 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

@mikepitre
mikepitre enabled auto-merge (squash) November 11, 2026 13:00
@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10768

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10768

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10768

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10768

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10768

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10768

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10768

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10768

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10768

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10768

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10768

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10768

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10768

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10768

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10768

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10768

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10768

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10768

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10768

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10768

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10768

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10768

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10768

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10768

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10768

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10768

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10768

commit: e635dff

@mikepitre
mikepitre merged commit a331f11 into main Nov 11, 2026
62 checks passed
@mikepitre
mikepitre deleted the mike/stoic-feynman-th2tp0 branch November 11, 2026 13:14

This branch was successfully deployed

2 active deployments
Preview – swingset — e635dff4 Deployed Nov 11, 2026 by vercel[bot]
Preview – clerk-js-sandbox — e635dff4 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants