Skip to content

fix: include the last row in 2D zone detection and order manual zone y bounds - #4450

Draft
lpatiny wants to merge 1 commit into
mainfrom
fix-2d-zone-detection
Draft

lpatiny wants to merge 1 commit into
mainfrom
fix-2d-zone-detection

Conversation

@lpatiny

@lpatiny lpatiny commented Nov 21, 2026

Copy link
Copy Markdown
Member

The sub-matrix used for zone detection dropped the last row of the selection and started min/max from the wrong ends. A manual zone also swapped its y bounds based on the x condition. Adds tests on a simulated COSY.

Assisted-By: Claude Opus 5 noreply@anthropic.com

…y bounds

Assisted-By: Claude Opus 5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: f194e08
Status: ✅  Deploy successful!
Preview URL: https://9fc13f9b.nmrium.pages.dev
Branch Preview URL: https://fix-2d-zone-detection.nmrium.pages.dev

View logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant