Repository navigation
Include the error in literal validator messages - #1674
Merged
TristonianJones merged 1 commit intoNov 18, 2026
Merged
TristonianJones merged 1 commit into
TristonianJones merged 1 commit into
Conversation
`formatValidator.Validate` reports an invalid literal as only `invalid <function> argument`, dropping the error returned by the check. For `ValidateRegexLiterals` that error says what is wrong with the pattern, which is the part a user needs to fix it. Report the error after the message, matching what `networkFormatValidator` in `ext/network.go` already does. This applies to `ValidateDurationLiterals`, `ValidateTimestampLiterals`, and `ValidateRegexLiterals`, which share `formatValidator`.
stefanvanburen
marked this pull request as ready for review
November 18, 2026 22:08
TristonianJones
approved these changes
Nov 18, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatValidator.Validatedrops the error from its check and only reportsinvalid <function> argument, which doesn't say what's actually wrong with the literal. This appends the error, the same waynetworkFormatValidatorinext/network.goalready does, so e.g.ValidateRegexLiteralsgoes from:to:
Evaluating the same expression (or building the program with
OptOptimize) already returns the fullerror parsing regexp: ...error, so this just makes the compile-time check match.Noticed this while trying out
ValidateRegexLiteralsinbuf lintfor protovalidate rules, where the old message leaves you guessing which part of the regex is broken. The duration and timestamp validators shareformatValidator, so they pick up the extra detail too (the duration one is less helpful, sinceevalCalljust gives back a type conversion error, but it's no worse than before).