Repository navigation
Limit unary minus to the declared numeric types - #1673
Open
powerman2026 wants to merge 2 commits into
Open
powerman2026 wants to merge 2 commits into
powerman2026 wants to merge 2 commits into
Conversation
Duration and bool implement the same negation trait as int and double. Check the runtime CEL type so dynamic inputs follow the declarations.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1646.
The checker allows unary minus for int and double. The interpreter dispatched it through the negation trait, which duration also implements. As a result, changing a duration expression's static type to dyn could change a type error into a valid negative duration.
Check the CEL type before calling the trait implementation. The interpreter table covers dynamic duration and bool rejection and successful int and double negation across its evaluation modes.
On master the new duration case returned
-1sinstead of an overload error. The targeted tests andgo test -race ./...pass with the change.