Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eval/compiler/flat_expr_builder_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,6 @@ absl::Status RunTernaryExpression(CelValue selector, CelValue value1,
CEL_ASSIGN_OR_RETURN(auto cel_expr,
builder.CreateExpression(&expr, &source_info));

std::string variable = "test";

Activation activation;
activation.InsertValue("selector", selector);
Expand Down
1 change: 0 additions & 1 deletion eval/eval/ident_step_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ TEST(IdentStepTest, TestIdentStepNameNotFound) {

Activation activation;
Arena arena;
std::string value("test");

absl::StatusOr<CelValue> status0 = impl.Evaluate(activation, &arena);
ASSERT_THAT(status0, IsOk());
Expand Down
1 change: 0 additions & 1 deletion eval/eval/ternary_step_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class LogicStepTest : public testing::TestWithParam<bool> {
IdentifierTable{{"name0", 0}, {"name1", 1}, {"name2", 2}}));

Activation activation;
std::string value("test");

activation.InsertValue("name0", arg0);
activation.InsertValue("name1", arg1);
Expand Down
2 changes: 1 addition & 1 deletion eval/public/builtin_func_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ class BuiltinsTest : public ::testing::Test {

void TestComparisonsForType(CelValue::Type kind, const CelValue& ref,
const CelValue& lesser) {
std::string type_name = CelValue::TypeName(kind);
[[maybe_unused]] std::string type_name = CelValue::TypeName(kind);

TestComparison(builtin::kEqual, ref, ref, true);
TestComparison(builtin::kEqual, ref, lesser, false);
Expand Down
4 changes: 0 additions & 4 deletions eval/public/unknown_attribute_set_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ using cel::expr::Expr;

TEST(UnknownAttributeSetTest, TestCreate) {
const std::string kAttr1 = "a1";
const std::string kAttr2 = "a2";
const std::string kAttr3 = "a3";

std::shared_ptr<CelAttribute> cel_attr = std::make_shared<CelAttribute>(
"root", std::vector<CelAttributeQualifier>(
Expand All @@ -38,8 +36,6 @@ TEST(UnknownAttributeSetTest, TestCreate) {

TEST(UnknownAttributeSetTest, TestMergeSets) {
const std::string kAttr1 = "a1";
const std::string kAttr2 = "a2";
const std::string kAttr3 = "a3";

CelAttribute cel_attr1(
"root", std::vector<CelAttributeQualifier>(
Expand Down
3 changes: 0 additions & 3 deletions internal/strings_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -817,9 +817,6 @@ TEST(StringsTest, UTF8Unescape) {
}

TEST(StringsTest, TestUnescapeErrorMessages) {
std::string error_string;
std::string out;

auto status_or_string = UnescapeString("\\2");
EXPECT_THAT(status_or_string, StatusIs(absl::StatusCode::kInvalidArgument));
EXPECT_TRUE(absl::StrContains(
Expand Down
Loading