Repository navigation
fix(iOS): support Unicode tab keys in Fabric events - #611
Open
oleksandrzavarzin-callstack wants to merge 6 commits into
Open
oleksandrzavarzin-callstack wants to merge 6 commits into
oleksandrzavarzin-callstack wants to merge 6 commits into
Conversation
oleksandrzavarzin-callstack
changed the title
thiagobrez
reviewed
Oct 30, 2026
Comment on lines
+60
to
+64
| name="앨범" | ||
| component={Albums} | ||
| options={{ | ||
| tabBarButtonTestID: 'albumsTestID', | ||
| tabBarLabel: 'Albums', |
Member
There was a problem hiding this comment.
Please create a new example page for this called "Unicode" or something similar, so we don't pollute the old example. You can copy-paste this one.
Contributor
Author
There was a problem hiding this comment.
Thank you for the comment.
I've added a new "Unicode" example screen.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #560. It is a continuation of @thiagobrez's work from #563.
Summary
On Fabric, the tab selection and long-press events converted the tab key with
cStringUsingEncoding:kCFStringEncodingUTF8. That method expects anNSStringEncoding, so it returnedNULLfor any non-ASCII key, and thestd::stringconstructor aborted the app. Both events now usestd::string([key UTF8String] ?: "").Changes on top of #563:
artifacts/issue-560/) are removed from the repository.main. The e2e flow is now inpackages/example-shared/e2e/.앨범, so the route key is non-ASCII.${APP_ID}like the other flows, and it finds tabs by their label.Results
Tested on iPhone 17 simulators with iOS 27.0.
main)SuQyOoAwC5pYm9c41Zj-FQ.mp4
cIPRdHY32xgHZbGCyvpSVQ.mp4
Additional testing results:
onPageSelectedWithKey:onPageSelectedWithKey:unicode-tab-key.yamlwith the fixunicode-tab-key.yamlwithout the fixWithout #587, long presses do not reach this code on iOS 26 and later (#573).