Repository navigation
fix(ios): respect disablePageAnimations during tab switches - #610
Open
LeleDallas wants to merge 1 commit into
Open
LeleDallas wants to merge 1 commit into
LeleDallas wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Note
This PR fixes
disablePageAnimationsnot being respected when switching tabs on iOS versions earlier than 26.The flag is now forwarded to the
UITabBarControllerDelegate, which provides a zero-duration transition when animations are disabled.When the flag is
false, UIKit's default transition behavior is preserved.This replaces the iOS workaround that temporarily disabled animations globally through
UIView.setAnimationsEnabled, keeping the change scoped to tab transitions.How to test?
<FourTabs disablePageAnimations />;<FourTabs />example and verify that default transition behavior is preserved;Screenshots
Screen.Recording.2026-10-30.at.10.26.56.mov
Screen.Recording.2026-10-30.at.10.27.45.mov