Repository navigation
fix(ios): book every surface on the lit panel, not the first window - #4122
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foldable surface commands name the lit panel and book a window by app bundle and request UUID. Capture, interaction, selectors and text probes reuse proven-lit roots. Typed refusals prevent outer-app fallback.
Required window-read exceptions now return
APP_SCREEN_UNRESOLVED; genuinely absent windows retainAPP_SCREEN_WINDOW_UNRESOLVEDand are not asked for frames.70 files in the full PR; this round changes two (+18/-1). No linked issue supplied.
Validation
Head
ec80eecb1e0251d51d93aa68071c88577f1ea7ba; basec8ad8fb1257787ce0973cf74271cb9a4fafb51d9.4d6f523plus the new native test fails five assertions across unreadable-only, unreadable-before-lit and unreadable-before-dark lists. At head, six selected native tests pass, including absent-window and ordinary booking controls.pnpm check:affected --run --head ec80eecbpassed; receipt.tmp/validation/run-RD6UYM/receipt.json,exactCommit=true,checkoutChanged=false; 11 passed, 10 skipped, 1 deduplicated. Vitest: 18,215 passed, 1 skipped, 0 failed.4d6f523; earlier live evidence retains its attribution. The exception regression uses native fault injection on iOS 27.1 Duo. No natural exception is claimed.Hosted checks at this head: 17 succeeded, one optional matrix lane skipped, none failed. Human review approval remains outstanding.