Repository navigation
fix(pg): refuse ReadyForQuery before authentication completes - #3844
Open
AadiBolics wants to merge 5 commits into
Open
AadiBolics wants to merge 5 commits into
AadiBolics wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3841.
During connect, Client accepted the first ReadyForQuery as a finished connection regardless of what came before it. A server that answers the startup message with ReadyForQuery alone, with no authentication request, connects successfully and the configured password is never requested. libpq refuses the same server.
The fix tracks authenticationOk and accepts the first ReadyForQuery only after authentication has completed. A ReadyForQuery arriving while connecting without a prior AuthenticationOk now fails connect() with "expected authentication request from server, but received Z" and closes the connection. The protocol requires every authentication exchange, including trust auth, to end with AuthenticationOk, so conforming servers are unaffected.
Tests: a new ready-for-query-before-auth-tests.js uses a scripted TCP server to assert connect() fails when ReadyForQuery arrives with no authentication, and still succeeds after AuthenticationOk. The unit test helper and the two tests with hand-rolled connections now emit authenticationOk, mirroring the real handshake. The full test/unit suite passes locally.