Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A quantized
Linear8bitLtmoves its weight and scale caches intoself.stateon the first forward. Its checkpoint loader subsequently looks only atweight.SCB, which is nowNone, so reloading an otherwise valid checkpoint incorrectly raises the error for an unquantized module. This also prevents switching between saved quantized weights after inference or training has started.Change
Restore scales into the active scale buffer, using
state.SCBwhen the weight-owned buffer has already moved. Keep the state reference bound to that buffer after copying checkpoint values. The existing error for genuinely uninitialized quantization buffers remains in place.Validation
Base:
a616886cacf86701514f0cb1d6be760f967481c0.tests/test_linear8bitlt.pymodule excluding compiler-specific cases: 47 passed, 4 skipped, 16 deselected.git diff --checkpass.BNB_TEST_DEVICE=cpu OMP_NUM_THREADS=2 python -m pytest tests/test_linear8bitlt.py -k 'not torch_compile' -qPython 3.12.14 / PyTorch 2.15.0+cpu, with the current native CPU library built from source. GPU execution, compiler-specific tests and the full repository suite were not run.
The failure described in #960 reproduces on this base. Checked all-state checkpoint/reload searches and the actual related serialization changes #159, #1099, #1865 and #2129; none restores the state-owned scale buffer on this load path.