Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedding4bitalready gathers the packed rows and their scales for the requested token IDs. It then deep-copies the full weight quantization state, including the vocabulary-wideabsmaxtensor, only to overwrite that copy with the gathered scales.Use a shallow copy of the state. Assigning
absmaxandshapeon the copy leaves the weight's state intact, and dequantization only reads the other fields.GPU measurements
Single NVIDIA A10, PyTorch 2.13.0+cu130, bitsandbytes at
a616886with the CUDA 13.0 native library from 0.50.2. The NF4 table had 65,536 rows, 4,096 columns, FP16 source weights and a 16 MiB scale tensor.Peak is the increase in
torch.cuda.max_memory_allocated()over the allocation immediately before one warmed-up lookup, including its output. Timing is the median of seven synchronized batches of 100 calls after 20 warmups. Each configuration matchedF.embedding(ids, dequantize_4bit(weight, state))exactly.The existing
test_embedding_losslessandtest_embedding_errorcases passed on CUDA (60 passed). All pre-commit hooks passed.