Repository navigation
fix(key): support all BIP39 word counts and reject invalid values in key generate - #366
Open
Olorunshogo wants to merge 2 commits into
Open
Olorunshogo wants to merge 2 commits into
Olorunshogo wants to merge 2 commits into
Conversation
|
Looks good to me. I'll test it later. |
emma31-dev
approved these changes
Oct 25, 2026
emma31-dev
left a comment
emma31-dev
left a comment
There was a problem hiding this comment.
Aside that minor issue everything looks good. I have tested everything and its adapted well.
| cli.key_cmd(&["generate", "--entropy", word_count]) | ||
| .assert() | ||
| .failure() | ||
| .stderr(predicate::str::contains("possible values")); |
There was a problem hiding this comment.
This is an unnecessary assertion but can be overlooked
Contributor
Author
|
Please take a look at this @tvpeter @vadim-anfv |
|
@Olorunshogo it has been 2 days . Relax as older PRs will get reviewed before this |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 59.08% 59.14% +0.06%
==========================================
Files 25 25
Lines 4646 4651 +5
==========================================
+ Hits 2745 2751 +6
+ Misses 1901 1900 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Description
key generate --entropyonly matched12; every other value was silently coerced to a 24-word mnemonic. BIP39 andbdk_walletsupport 12, 15, 18, 21 and 24 words.--entropynow parses into aMnemonicWordCountValueEnumlimited to those five values, so invalid input is rejected at parse time and--helplists the options. The flag name,-e,WORD_COUNTenv var and default of12are unchanged.Fixes #362
--entropy12/ default15/18/21240/13/999Notes to reviewers
WordCountderives no traits (noClone), so clap can't parse into it directly.MnemonicWordCountmirrors it with aFromimpl, following theScriptTypepattern used bycompile --type.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: