Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The exposed restore and undo-send actions can bypass send-confirmation safeguards or misreport a successful recall, risking unintended delivery or retries that recall another message.
2 open issues
What changed in this PR
Updates hey-cli to HEY SDK v0.36.0 and synchronizes its embedded MCP API models and Nix dependency hash.
Changes:
- Bumps the Go SDK dependency and checksums from v0.35.1 to v0.36.0.
- Adds entry restoration and delayed-send recall to the MCP models, and updates Undo Send scope documentation.
- Refreshes model provenance and the Nix vendor hash.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
nix/package.nix |
Refreshes the dependency vendor hash. |
internal/mcpserver/model/PROVENANCE.json |
Records the SDK v0.36.0 source revision. |
internal/mcpserver/model/openapi.json |
Adds restore and undo-send operations; updates scope documentation. |
internal/mcpserver/model/behavior-model.json |
Adds behavior metadata for both operations. |
go.sum |
Updates SDK dependency checksums. |
go.mod |
Pins the SDK to v0.36.0. |
Review effort: Balanced
| "/entries/{entryId}/status/active.json": { | ||
| "put": { | ||
| "description": "Restore an entry from the trash (Entries::StatusController#active): a trashed draft\nbecomes a draft again, and a trashed message that had been sent or received returns to\nits thread. An entry that is not in the trash is left as it is, so asking twice is\nharmless. HEY first delivers an entry Undo Send still holds, as its other status changes\ndo, so this is not a way to call a send back (UndoTopicSend is).\n\nThe entry alone is restored, never its topic. A draft that was the only entry of its\ntopic took the topic to the trash with it (DeleteDraft), and restoring just the entry\nleaves a draft on a trashed topic, which HEY empties from the trash with the rest:\nrestore that one with RestoreTopic, which brings back the topic and the draft together.\nThis operation is for a draft trashed out of a thread that stayed, which RestoreTopic\nleaves in the trash.\n\nHEY answers with a redirect and no body, 303 to the entry's topic. A generated client\nfollows it and reads the thread; Go's wrapper takes the redirect as the answer.\nTypeScript's client follows no redirect: there the 303 arrives as an error whose status\nis 303, and that status is the restore having gone through. A scoped token needs write,\nand send as well when the draft is scheduled to send, since a draft keeps its schedule\nin the trash.", | ||
| "operationId": "RestoreEntry", |
| "/topics/{topicId}/undo_send.json": { | ||
| "post": { | ||
| "description": "Call back the last message the caller sent on a topic, while Undo Send still holds it\n(Topics::UndoSendsController#create). The message returns to Drafts, unsent. HEY picks\nthe message: the caller's last delayed entry on the topic, which need not be the one a\ncaller has in mind when two were sent to one thread within the delay. A reply that broke\nout into a thread of its own is called back on that thread, the one SentMessage's\ntopic_id names, and returns to the thread it answered.\n\nHEY answers a success with a redirect and no body, 303 to the draft: /messages/{entryId}/edit\nfor a new message, /topics/{topicId}?expanded_draft={entryId} for a reply. That Location\nis the only place HEY names the entry it called back. A generated client follows the\nredirect and reads the draft or its thread, which says the undo went through and not\nwhich entry it was; the Go, Rust, Kotlin and Swift conveniences send it without\nfollowing and answer the entry. TypeScript's client follows no redirect: there the 303\narrives as an error whose status is 303, and that status is the undo having gone through.\nWith nothing left to call back (the delay ran out and the message went, or none was held)\nHEY answers 400 and changes nothing. A scoped token needs write.\n\nNever sent again after a failure: a second undo calls back the next delayed entry.", | ||
| "operationId": "UndoTopicSend", |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bumps
github.com/basecamp/hey-sdk/gofrom v0.35.1 to v0.36.0. Opened by coworker's sdk-bump, the backstop for Dependabot: no Dependabot PR 9h after the release. It opens whether or not the bump builds: what broke is the to-do list.Build
go get github.com/basecamp/hey-sdk/go@v0.36.0,go mod tidy,scripts/sync-mcp-model.sh SDK_CHECKOUTTests run in this PR's CI.
SDK changes since v0.35.1
Releases: v0.36.0. Read MIGRATING.md for the breaks a clean build won't show.
Other SDK bumps
Summary by cubic
Bumps
github.com/basecamp/hey-sdk/gofrom v0.35.1 to v0.36.0 and re-syncs the MCP model files (PROVENANCE.json,behavior-model.json,openapi.json) and NixvendorHash. The build,go vet, and CI tests pass.New Features
RestoreEntrybrings a trashed entry back to its thread.UndoTopicSendcalls back a delayed message that Undo Send still holds.undo_actiondescription on sent messages to reflect the widenedwritescope.Written for commit d05b931. Summary will update on new commits.