Repository navigation
deps: bump github.com/basecamp/mcp to 2026-11-18, titling each domain - #663
Merged
Merged
Conversation
The toolkit's August pin was 50 commits behind. Since then the catalog refuses a domain without a title, which connector directories require on every tool, so each of hey mcp's domains gets one. go-sdk moves to the pseudo-version the toolkit builds on, and the Nix vendorHash follows go.sum.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The catalog misclassifies destructive deletions, advertises unsafe retries for writes, and describes pagination fields that MCP responses do not expose.
3 open issues
What changed in this PR
Updates hey mcp to the newer shared toolkit and supplies the domain titles its catalog now requires.
Changes:
- Bumps the MCP toolkit and aligns the MCP Go SDK dependency.
- Adds human-readable titles to all seven MCP domains.
- Refreshes dependency checksums and the Nix vendor hash.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| nix/package.nix | Updates the vendor hash for the dependency changes. |
| internal/mcpserver/domains.go | Adds the seven required MCP domain titles. |
| go.sum | Records checksums for the updated dependencies. |
| go.mod | Updates the MCP toolkit and Go SDK pins. |
Review effort: Balanced
The toolkit's describe now serves each operation's HTTP pagination and retry policy from the model. Neither is how a client talks to hey mcp: a paged read answers its next page as a cursor in the result, never as the Link or X-Total-Count headers the model describes, and every write goes out once, so a client that followed a write's retry policy could save a draft or toggle a calendar twice. Paginated stays, saying a read has more pages.
Member
Author
|
Review summary at 522f4d4:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Moves
github.com/basecamp/mcpfrom its 2026-08-28 pin tov0.0.0-20261118214004-663b2e5d2836, the toolkit's current main, 50 commits on.Changes the bump required:
Title("connector directories require a title on every tool"), so everyhey mcpdomain gets one: HEY Boxes, HEY Search, HEY Threads, HEY Contacts & Screener, HEY Calendar To-dos, HEY Calendars, HEY Identity. Without them,hey mcpfailed to derive its catalog at startup.github.com/modelcontextprotocol/go-sdkmoves from v1.8.0 to the v1.8.1 pseudo-version the toolkit builds on.vendorHashfollows go.sum, viamake update-nix-hash, which reported a successful build.Not in this PR: the toolkit also adds result paging and a size cap (
result.Middleware/PagingMiddleware).hey mcpdoesn't wire those in yet. That's a behaviour change of its own and will come with the shared server package.make checkpasses.Summary by cubic
Bumps
github.com/basecamp/mcpfrom its 2026-08-28 pin to the toolkit's current main, 50 commits ahead. The catalog now requires aTitleon every domain, so all sevenhey mcpdomains get one.github.com/modelcontextprotocol/go-sdkto the v1.8.1 pseudo-version the toolkit builds on.vendorHashviamake update-nix-hash.The toolkit's describe now serves each operation's HTTP pagination and retry policy from the model.
hey mcpstrips both: a paged read answers its next page as a cursor in the result, never as the Link or X-Total-Count headers the model describes, and writes go out once, so a client that followed a write's retry policy could save or toggle twice.Paginatedstays.Written for commit 522f4d4. Summary will update on new commits.