Skip to content

deps: bump github.com/basecamp/mcp to 2026-11-18, titling each domain - #663

Merged
jeremy merged 2 commits into
mainfrom
bump-mcp-toolkit
Nov 19, 2026
Merged

jeremy merged 2 commits into
mainfrom
bump-mcp-toolkit

Conversation

@jeremy

@jeremy jeremy commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Moves github.com/basecamp/mcp from its 2026-08-28 pin to v0.0.0-20261118214004-663b2e5d2836, the toolkit's current main, 50 commits on.

Changes the bump required:

  • Domain titles. The toolkit's catalog now refuses a domain without a Title ("connector directories require a title on every tool"), so every hey mcp domain gets one: HEY Boxes, HEY Search, HEY Threads, HEY Contacts & Screener, HEY Calendar To-dos, HEY Calendars, HEY Identity. Without them, hey mcp failed to derive its catalog at startup.
  • go-sdk. github.com/modelcontextprotocol/go-sdk moves from v1.8.0 to the v1.8.1 pseudo-version the toolkit builds on.
  • Nix. vendorHash follows go.sum, via make update-nix-hash, which reported a successful build.

Not in this PR: the toolkit also adds result paging and a size cap (result.Middleware / PagingMiddleware). hey mcp doesn't wire those in yet. That's a behaviour change of its own and will come with the shared server package.

make check passes.


Summary by cubic

Bumps github.com/basecamp/mcp from its 2026-08-28 pin to the toolkit's current main, 50 commits ahead. The catalog now requires a Title on every domain, so all seven hey mcp domains get one.

  • Moves github.com/modelcontextprotocol/go-sdk to the v1.8.1 pseudo-version the toolkit builds on.
  • Updates the Nix vendorHash via make update-nix-hash.

The toolkit's describe now serves each operation's HTTP pagination and retry policy from the model. hey mcp strips both: a paged read answers its next page as a cursor in the result, never as the Link or X-Total-Count headers the model describes, and writes go out once, so a client that followed a write's retry policy could save or toggle twice. Paginated stays.

Written for commit 522f4d4. Summary will update on new commits.

View guided diff Turn on auto-fix

The toolkit's August pin was 50 commits behind. Since then the catalog
refuses a domain without a title, which connector directories require on
every tool, so each of hey mcp's domains gets one. go-sdk moves to the
pseudo-version the toolkit builds on, and the Nix vendorHash follows go.sum.
@jeremy
jeremy requested a review from a team as a code owner November 19, 2026 01:24
Copilot AI balanced review requested due to automatic review settings November 19, 2026 01:24
@github-actions github-actions Bot added the deps label Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The catalog misclassifies destructive deletions, advertises unsafe retries for writes, and describes pagination fields that MCP responses do not expose.

3 open issues
What changed in this PR

Updates hey mcp to the newer shared toolkit and supplies the domain titles its catalog now requires.

Changes:

  • Bumps the MCP toolkit and aligns the MCP Go SDK dependency.
  • Adds human-readable titles to all seven MCP domains.
  • Refreshes dependency checksums and the Nix vendor hash.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
nix/​package.nix Updates the vendor hash for the dependency changes.
internal/​mcpserver/​domains.go Adds the seven required MCP domain titles.
go.sum Records checksums for the updated dependencies.
go.mod Updates the MCP toolkit and Go SDK pins.

Review effort: Balanced

Comment thread go.mod Resolved
Comment thread go.mod Resolved
Comment thread go.mod Resolved
The toolkit's describe now serves each operation's HTTP pagination and retry
policy from the model. Neither is how a client talks to hey mcp: a paged read
answers its next page as a cursor in the result, never as the Link or
X-Total-Count headers the model describes, and every write goes out once, so
a client that followed a write's retry policy could save a draft or toggle a
calendar twice. Paginated stays, saying a read has more pages.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The describe payload incorrectly marks two actions as non-destructive even though they can overwrite or clear stored data, potentially misleading clients.

3 open issues
1 resolved since last review

Review effort: Balanced

Comment thread go.mod Resolved
@jeremy

jeremy commented Nov 19, 2026 •

Copy link
Copy Markdown
Member Author

Review summary at 522f4d4:

  • Fixed: describe no longer serves wire pagination or retry policy (thread, thread).
  • Declined: per-action destructive traits for box groups and designations (thread) and for contact updates (thread). These traits come from hey-sdk's behavior model, so a change to them is made there, where it reaches every HEY server at once.

@jeremy
jeremy merged commit 2265316 into main Nov 19, 2026
37 checks passed
@jeremy
jeremy deleted the bump-mcp-toolkit branch November 19, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants