Repository navigation
Conversation
A boost on the agent's comment in a served project reaches the agent, but the same boost on its line in a Ping was discarded at the gate as no_route: a Ping is never a served project, and the boosted rule required one. The boosted rule now stays open outside a served project for the connector that hears the agent's Pings. Decide asks the Ping read, as it does for a line, and admits the boost only in a Ping, from an operator or a person let into that Ping, on a line the agent wrote. A boost in an unserved project is still discarded as no_route, and a connector that does not hear Pings still discards it unread. The operator's boost there may answer a declared ask, as it does in a project; it is never the owner's word.
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues block the change enabling boosts on the agent’s own Ping lines.
No open issues 🎉
What changed in this PR
This PR lets the connector receive boosts on the agent’s own Ping lines, extending existing project-boost behavior while preserving Ping trust and routing restrictions.
Changes:
- Admits Ping boosts from operators and explicitly allowed participants when the connector hears Pings.
- Adds admission and rejection tests, including the extra Ping lookup for boosts in unserved projects.
- Updates admission documentation and worker guidance to reflect Ping boost support.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
skills/basecamp-connect/subagent.md |
Removes outdated guidance that Ping boosts never reach the agent. |
internal/connector/admission/verdict.go |
Resolves Ping context and admits boosts on the agent’s own lines. |
internal/connector/admission/ping_boosts_test.go |
Tests Ping boost admission, trust restrictions, and configuration handling. |
internal/connector/admission/matrix.go |
Marks the boosted rule as eligible for Ping handling. |
internal/connector/admission/gate.go |
Allows eligible boosts through the gate when Pings are enabled. |
internal/connector/admission/doc.go |
Documents Ping lookup and boost admission behavior. |
internal/connector/admission/boost_test.go |
Checks lookup costs for boosts in unserved projects. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A boost on the agent's own comment in a project it serves reaches the agent. The same boost on the agent's own line in a Ping was dropped as
no_route, and the person who boosted saw no sign of it. A Ping is never a served project, and the boosted rule required one.Basecamp card: Boosting an agent's line in a Ping never reaches it, and nothing says so
What changes
HeardInPings. For the connector that hears the agent's Pings (--pings), the gate keeps the rule open outside a served project.Decidethen asks the Ping read, the same read a line gets.--allow-in-pinglet into that one Ping (as a participant).no_route, and a connector that doesn't hear Pings still discards it before any read. Agents, delegated boosts and a booster who isn't the performer are refused as before. A project member under project trust is still nobody in a Ping.Owner, so it never counts as the owner's word on the connector.subagent.mdno longer says a boost in a Ping never reaches the agent.Cost
When a connector hears Pings, a boost in a project it doesn't serve now costs one Ping read before it is discarded. Before, it was discarded with no read. A chat line there already costs that read.
Tests
ping_boosts_test.gocovers:Against
main, the admitting cases fail.TestABoostSettledFromItsPointerCostsNoReadnow pins the one Ping read when Pings are heard, and still pins zero reads when they aren't.bin/cipasses locally.Summary by cubic
Boosts on the agent's own line in a Ping now reach the agent. Previously, they were discarded as
no_route: a Ping is never a served project, and the boosted rule required one.HeardInPings: a connector that hears Pings asks the Ping read, and admits the boost only when the bucket is a Ping, the line is the agent's own, and the booster is an operator or a participant let in with--allow-in-ping.no_route, and a connector that does not hear Pings still discards them before any read.Cost
When a connector hears Pings, a boost in an unserved project now costs one Ping read before being discarded. Previously it was discarded with no read.
Written for commit 3f3974c. Summary will update on new commits.