Skip to content

Hear a boost on the agent's line in a Ping - #1047

Open
robzolkos wants to merge 1 commit into
mainfrom
ping-boosts
Open

robzolkos wants to merge 1 commit into
mainfrom
ping-boosts

Conversation

@robzolkos

@robzolkos robzolkos commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

A boost on the agent's own comment in a project it serves reaches the agent. The same boost on the agent's own line in a Ping was dropped as no_route, and the person who boosted saw no sign of it. A Ping is never a served project, and the boosted rule required one.

Basecamp card: Boosting an agent's line in a Ping never reaches it, and nothing says so

What changes

  • The boosted rule now has HeardInPings. For the connector that hears the agent's Pings (--pings), the gate keeps the rule open outside a served project. Decide then asks the Ping read, the same read a line gets.
  • A boost is admitted there only when the bucket is a Ping, the boosted line is the agent's own, and the booster is someone who can already mention the agent in that Ping: an operator, or a person --allow-in-ping let into that one Ping (as a participant).
  • Unchanged: a boost in an unserved project is still discarded as no_route, and a connector that doesn't hear Pings still discards it before any read. Agents, delegated boosts and a booster who isn't the performer are refused as before. A project member under project trust is still nobody in a Ping.
  • As in a project, the operator's own boost names the line as the ask it would answer, so a declared ask in a Ping can get its go. Any other booster's boost names none. A boost is never Owner, so it never counts as the owner's word on the connector.
  • subagent.md no longer says a boost in a Ping never reaches the agent.

Cost

When a connector hears Pings, a boost in a project it doesn't serve now costs one Ping read before it is discarded. Before, it was discarded with no read. A chat line there already costs that read.

Tests

ping_boosts_test.go covers:

  • the operator's boost in a direct Ping and in a group Ping
  • a participant's boost
  • boosts on someone else's line
  • a person let into a different Ping
  • a member under project trust
  • agents and delegated boosts
  • a connector that doesn't hear Pings
  • an unreadable connect.json

Against main, the admitting cases fail. TestABoostSettledFromItsPointerCostsNoRead now pins the one Ping read when Pings are heard, and still pins zero reads when they aren't. bin/ci passes locally.


Summary by cubic

Boosts on the agent's own line in a Ping now reach the agent. Previously, they were discarded as no_route: a Ping is never a served project, and the boosted rule required one.

  • The boosted rule is now HeardInPings: a connector that hears Pings asks the Ping read, and admits the boost only when the bucket is a Ping, the line is the agent's own, and the booster is an operator or a participant let in with --allow-in-ping.
  • Boosts in an unserved project are still discarded as no_route, and a connector that does not hear Pings still discards them before any read.
  • Agents, delegated boosts, and boosters who aren't the performer are refused as before; a project-trust member is still nobody in a Ping.
  • The operator's own boost in a Ping may answer a declared ask, as in a project; it is never the owner's word.

Cost

When a connector hears Pings, a boost in an unserved project now costs one Ping read before being discarded. Previously it was discarded with no read.

Written for commit 3f3974c. Summary will update on new commits.

View guided diff Turn on auto-fix

A boost on the agent's comment in a served project reaches the agent, but
the same boost on its line in a Ping was discarded at the gate as no_route:
a Ping is never a served project, and the boosted rule required one.

The boosted rule now stays open outside a served project for the connector
that hears the agent's Pings. Decide asks the Ping read, as it does for a
line, and admits the boost only in a Ping, from an operator or a person
let into that Ping, on a line the agent wrote. A boost in an unserved
project is still discarded as no_route, and a connector that does not hear
Pings still discards it unread. The operator's boost there may answer a
declared ask, as it does in a project; it is never the owner's word.
@robzolkos
robzolkos requested a review from a team as a code owner November 19, 2026 16:55
Copilot AI balanced review requested due to automatic review settings November 19, 2026 16:55
@github-actions github-actions Bot added tests Tests (unit and e2e) skills Agent skills labels Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues block the change enabling boosts on the agent’s own Ping lines.

No open issues 🎉

What changed in this PR

This PR lets the connector receive boosts on the agent’s own Ping lines, extending existing project-boost behavior while preserving Ping trust and routing restrictions.

Changes:

  • Admits Ping boosts from operators and explicitly allowed participants when the connector hears Pings.
  • Adds admission and rejection tests, including the extra Ping lookup for boosts in unserved projects.
  • Updates admission documentation and worker guidance to reflect Ping boost support.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
skills/​basecamp-connect/​subagent.md Removes outdated guidance that Ping boosts never reach the agent.
internal/​connector/​admission/​verdict.go Resolves Ping context and admits boosts on the agent’s own lines.
internal/​connector/​admission/​ping_boosts_test.go Tests Ping boost admission, trust restrictions, and configuration handling.
internal/​connector/​admission/​matrix.go Marks the boosted rule as eligible for Ping handling.
internal/​connector/​admission/​gate.go Allows eligible boosts through the gate when Pings are enabled.
internal/​connector/​admission/​doc.go Documents Ping lookup and boost admission behavior.
internal/​connector/​admission/​boost_test.go Checks lookup costs for boosts in unserved projects.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills Agent skills tests Tests (unit and e2e)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants