Skip to content

Bump the basecamp/mcp toolkit, and title every MCP tool - #1045

Merged
jeremy merged 1 commit into
mainfrom
bump-mcp-toolkit
Nov 19, 2026
Merged

jeremy merged 1 commit into
mainfrom
bump-mcp-toolkit

Conversation

@jeremy

@jeremy jeremy commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Moves github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5. go-sdk moves with it to the toolkit's own pin.

What broke

The code still compiled, but basecamp mcp could no longer start. The toolkit now derives each gateway tool's annotations (title, idempotent, destructive, and open-world false), and both its catalog loader and gateway.New refuse a domain without a title. None of our domains had one, so every server test failed with domain "projects" has no title.

Fix

  • Each DomainSpec gets a Basecamp … title, the form the HEY and Fizzy MCP servers use (HEY Boxes, Fizzy Cards).
  • The hand-built recordings composite domain gets Basecamp Recordings.
  • nix/package.nix has a refreshed vendorHash for the new go.sum. It came from make update-nix-hash, and the rebuild with it succeeded.

The catalog snapshot changes only by the toolkit's new (destructive) notes. These cover the 23 delete_*, destroy_*, remove_*, trash_* and unsubscribe* actions that its action-name classifier marks. Clients now also see these actions as destructiveHint: true.

Checks

bin/ci passes except for 13 PTY/terminal tests in appctx, cli, commands, connector/runner, stdinarg and tui/resolve. All 13 fail the same way on unmodified main in the local sandbox. CI is the judge for those.


Summary by cubic

Bumps github.com/basecamp/mcp to a pin that starts deriving gateway tool annotations and refuses domains without a title, which broke basecamp mcp startup. Every domain now carries a Basecamp … title in the HEY/Fizzy style, including the composite recordings domain.

  • The catalog snapshot changes only by the toolkit's new (destructive) notes on the 23 delete/destroy/remove/trash/unsubscribe actions, which now also reach clients as destructiveHint.
  • go-sdk moves with the toolkit pin, and nix/package.nix gets a refreshed vendorHash from make update-nix-hash.

Written for commit 5ea4eec. Summary will update on new commits.

View guided diff Turn on auto-fix

Move github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5,
which carries the result paging and size-cap middleware and the eval
multi-turn mode. go-sdk moves with it to the toolkit's own pin, so the
flake's vendorHash is refreshed (make update-nix-hash, build verified).

The toolkit now derives every gateway tool's annotations (title,
idempotent, destructive, closed world) and refuses a domain without a
title, so `basecamp mcp` failed to start: every catalog domain is untitled.
Give each DomainSpec a "Basecamp ..." title, the shape the HEY and Fizzy
servers use, and give the hand-built recordings domain one too.

The catalog snapshot moves by exactly the toolkit's new "destructive" notes:
the delete_*, destroy_*, trash_*, remove_* and unsubscribe actions its
action-name classifier marks, which now also reach clients as
destructiveHint.
@jeremy
jeremy requested a review from a team as a code owner November 19, 2026 01:21
Copilot AI balanced review requested due to automatic review settings November 19, 2026 01:21
@github-actions github-actions Bot added the deps label Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are recorded for the MCP toolkit update and domain-title additions.

No open issues 🎉

What changed in this PR

Updates the MCP toolkit and adds the domain titles it now requires, keeping basecamp mcp compatible with the new startup validation and tool metadata.

Changes:

  • Bumps the MCP toolkit and aligns the MCP Go SDK dependency.
  • Adds Basecamp … titles to all 16 standard domains and the composite recordings domain.
  • Updates the catalog snapshot with 23 destructive-action labels and refreshes the Nix vendor hash.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
nix/​package.nix Refreshes the vendor hash for the dependency changes.
internal/​mcpserver/​testdata/​catalog_snapshot.txt Records the toolkit’s destructive-action labels.
internal/​mcpserver/​domains.go Adds display titles to all standard MCP domains.
internal/​mcpserver/​composite.go Adds the composite recordings domain’s title.
go.sum Updates checksums for the changed dependencies.
go.mod Bumps the MCP toolkit and MCP Go SDK pins.

Review effort: Balanced

@jeremy

jeremy commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Review threads: none. Copilot approved on 5ea4eec with no findings.
CI: Race Detection shard 4 failed in its test-enumeration step before any test ran (shards 1-3 passed the same step); a rerun of the failed jobs passed.
Not reported on the head: cubic, 5ea4eec (its check ended neutral: the monthly review limit is reached, so it reviewed nothing).

@jeremy
jeremy merged commit 2032be2 into main Nov 19, 2026
57 of 59 checks passed
@jeremy
jeremy deleted the bump-mcp-toolkit branch November 19, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants