Repository navigation
Bump the basecamp/mcp toolkit, and title every MCP tool - #1045
Conversation
Move github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5, which carries the result paging and size-cap middleware and the eval multi-turn mode. go-sdk moves with it to the toolkit's own pin, so the flake's vendorHash is refreshed (make update-nix-hash, build verified). The toolkit now derives every gateway tool's annotations (title, idempotent, destructive, closed world) and refuses a domain without a title, so `basecamp mcp` failed to start: every catalog domain is untitled. Give each DomainSpec a "Basecamp ..." title, the shape the HEY and Fizzy servers use, and give the hand-built recordings domain one too. The catalog snapshot moves by exactly the toolkit's new "destructive" notes: the delete_*, destroy_*, trash_*, remove_* and unsubscribe actions its action-name classifier marks, which now also reach clients as destructiveHint.
There was a problem hiding this comment.
🟢 Approved
No active review issues are recorded for the MCP toolkit update and domain-title additions.
No open issues 🎉
What changed in this PR
Updates the MCP toolkit and adds the domain titles it now requires, keeping basecamp mcp compatible with the new startup validation and tool metadata.
Changes:
- Bumps the MCP toolkit and aligns the MCP Go SDK dependency.
- Adds
Basecamp …titles to all 16 standard domains and the composite recordings domain. - Updates the catalog snapshot with 23 destructive-action labels and refreshes the Nix vendor hash.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
nix/package.nix |
Refreshes the vendor hash for the dependency changes. |
internal/mcpserver/testdata/catalog_snapshot.txt |
Records the toolkit’s destructive-action labels. |
internal/mcpserver/domains.go |
Adds display titles to all standard MCP domains. |
internal/mcpserver/composite.go |
Adds the composite recordings domain’s title. |
go.sum |
Updates checksums for the changed dependencies. |
go.mod |
Bumps the MCP toolkit and MCP Go SDK pins. |
Review effort: Balanced
|
Review threads: none. Copilot approved on 5ea4eec with no findings. |
Moves
github.com/basecamp/mcpfrom the 2026-08-28 pin (2d6f44b) to663b2e5. go-sdk moves with it to the toolkit's own pin.What broke
The code still compiled, but
basecamp mcpcould no longer start. The toolkit now derives each gateway tool's annotations (title, idempotent, destructive, and open-world false), and both its catalog loader andgateway.Newrefuse a domain without a title. None of our domains had one, so every server test failed withdomain "projects" has no title.Fix
DomainSpecgets aBasecamp …title, the form the HEY and Fizzy MCP servers use (HEY Boxes,Fizzy Cards).recordingscomposite domain getsBasecamp Recordings.nix/package.nixhas a refreshedvendorHashfor the new go.sum. It came frommake update-nix-hash, and the rebuild with it succeeded.The catalog snapshot changes only by the toolkit's new
(destructive)notes. These cover the 23delete_*,destroy_*,remove_*,trash_*andunsubscribe*actions that its action-name classifier marks. Clients now also see these actions asdestructiveHint: true.Checks
bin/cipasses except for 13 PTY/terminal tests inappctx,cli,commands,connector/runner,stdinargandtui/resolve. All 13 fail the same way on unmodifiedmainin the local sandbox. CI is the judge for those.Summary by cubic
Bumps
github.com/basecamp/mcpto a pin that starts deriving gateway tool annotations and refuses domains without a title, which brokebasecamp mcpstartup. Every domain now carries aBasecamp …title in the HEY/Fizzy style, including the compositerecordingsdomain.(destructive)notes on the 23 delete/destroy/remove/trash/unsubscribe actions, which now also reach clients asdestructiveHint.go-sdkmoves with the toolkit pin, andnix/package.nixgets a refreshedvendorHashfrommake update-nix-hash.Written for commit 5ea4eec. Summary will update on new commits.