Repository navigation
Conversation
For HTTP/2 requests without a body, send HEADERS with END_STREAM instead of HEADERS followed by an empty DATA(END_STREAM) frame. A server may respond and reset the stream (RST_STREAM NO_ERROR, RFC 9113 section 8.1) before the trailing DATA frame is written, which previously failed a request whose response had already been received. Also ignore request write failures that happen after the response completed successfully. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
HttpToHttp2OutboundAdapter: bodyless requests now end the stream on the HEADERS frame, so no empty DATA frame is sent.NettyRequestExecutor: a write failure that happens after the response has already completed successfully is now ignored.H2ServerErrorTest,PingTimeoutTest,ServerCloseConnectionTest,ServerNotRespondingTest,WindowSizeTestandHttpToHttp2OutboundAdapterTest.EarlyResponseResetTestwith 14 cases..changes/next-release.Testing
netty-nio-clientmodule builds and its test suite passes on the branch, including the 14 new tests.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.AI tools
License