Repository navigation
Validate metadata paths in EC2MetadataUtils - #7551
Merged
Merged
Conversation
## Changes - `getData`, `getItems` and `fetchData` now throw `SdkClientException` when the path is `null` or does not start with `/`. The check runs before a metadata token is requested and before any connection is opened. - The request URL is now built with `SdkHttpUtils.appendUri`, so exactly one `/` separates the configured endpoint and the path. - `fetchData` with a `null` path now throws the same exception for both `force=true` and `force=false`. Before, the `force=false` case returned `null`. - The `fetchData` javadoc now says the path must be absolute and start with `/`.
dagnir
approved these changes
Nov 13, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EC2MetadataUtils` built the request URI by concatenating the configured endpoint and the caller-supplied path, without checking the path.
Motivation and Context
getItems,getData, andfetchDatanow require the path to start with/. Any other value, including null and empty, throws anSdkClientExceptionbefore any request is sent, including the token request.fetchDatavalidates the path before the cache lookup.SdkHttpUtils.appendUri.Testing
Added unit tests to
EC2MetadataUtilsTest:Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.AI tools
License