Skip to content

Generate GetModeledError for rpcv2Cbor errors that have members beyond Message - #4000

Merged
sbiscigl merged 1 commit into
mainfrom
cbor-modeled-errors
Nov 13, 2026
Merged

sbiscigl merged 1 commit into
mainfrom
cbor-modeled-errors

Conversation

@sbiscigl

Copy link
Copy Markdown
Collaborator

Description of changes:

When a service's model switches to smithy-rpc-v2-cbor, its exceptions with members beyond Message stop getting a GetModeledError specialization. Code that used to read those members now fails to link:

auto outcome = client.TranslateText(request);
// undefined reference to TranslateError::GetModeledError<TooManyTagsException>()
auto e = outcome.GetError().GetModeledError<Model::TooManyTagsException>();

This is a regression. Translate lost its 4 specializations in 1.11.908 and Shield lost its 4 in 1.11.927. 19 services are affected on main today.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
sbiscigl marked this pull request as ready for review November 12, 2026 22:07
@sbiscigl
sbiscigl requested a review from lucix-aws November 12, 2026 22:11
@sbiscigl
sbiscigl force-pushed the cbor-modeled-errors branch from fc92197 to 58b2736 Compare November 13, 2026 12:04
@sbiscigl
sbiscigl added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 5f8bcdc Nov 13, 2026
5 of 6 checks passed
@sbiscigl
sbiscigl deleted the cbor-modeled-errors branch November 13, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants