Repository navigation
Let S3 copy annotations on single-part S3CrtClient CopyObject - #3997
Merged
Merged
Conversation
sbiscigl
force-pushed
the
s3crt-small-copy-annotations
branch
from
November 11, 2026 21:42
3f7bdcc to
058fa55
Compare
sbiscigl
marked this pull request as ready for review
November 11, 2026 21:46
averyk22
approved these changes
Nov 11, 2026
sbiscigl
force-pushed
the
s3crt-small-copy-annotations
branch
2 times, most recently
from
November 12, 2026 18:05
7b55f1f to
44cbd75
Compare
sbiscigl
force-pushed
the
s3crt-small-copy-annotations
branch
from
November 13, 2026 14:37
44cbd75 to
e10a0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
github.com//issues/3991
Description of changes:
we already skip copying metadata and tags ourselves on small copies, since S3's single-part
CopyObjecthandles them. the annotation copy was just above that check instead of below it, so small copies were still reading and rewriting annotations for nothing. moved it below the check.tested with a new integration test that copies a small object and checks the annotations land with zero annotation calls from the client (it fails on the old code), and another that copies a 1 GiB object and checks the annotations come over. existing copy tests still pass.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.