Skip to content

Let S3 copy annotations on single-part S3CrtClient CopyObject - #3997

Merged
sbiscigl merged 1 commit into
mainfrom
s3crt-small-copy-annotations
Nov 13, 2026
Merged

sbiscigl merged 1 commit into
mainfrom
s3crt-small-copy-annotations

Conversation

@sbiscigl

Copy link
Copy Markdown
Collaborator

Issue #, if available:

github.com//issues/3991

Description of changes:

we already skip copying metadata and tags ourselves on small copies, since S3's single-part CopyObject handles them. the annotation copy was just above that check instead of below it, so small copies were still reading and rewriting annotations for nothing. moved it below the check.

tested with a new integration test that copies a small object and checks the annotations land with zero annotation calls from the client (it fails on the old code), and another that copies a 1 GiB object and checks the annotations come over. existing copy tests still pass.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
sbiscigl requested a review from averyk22 November 11, 2026 21:42
@sbiscigl
sbiscigl force-pushed the s3crt-small-copy-annotations branch from 3f7bdcc to 058fa55 Compare November 11, 2026 21:42
@sbiscigl
sbiscigl marked this pull request as ready for review November 11, 2026 21:46
@sbiscigl
sbiscigl force-pushed the s3crt-small-copy-annotations branch from 44cbd75 to e10a0d2 Compare November 13, 2026 14:37
@sbiscigl
sbiscigl added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 227ca1d Nov 13, 2026
4 of 6 checks passed
@sbiscigl
sbiscigl deleted the s3crt-small-copy-annotations branch November 13, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants