Skip to content

Qualify request types that clash with an operation name - #3995

Merged
sbiscigl merged 1 commit into
mainfrom
qualify-request-type-name-clash
Nov 12, 2026
Merged

sbiscigl merged 1 commit into
mainfrom
qualify-request-type-name-clash

Conversation

@sbiscigl

Copy link
Copy Markdown
Collaborator

Description of changes:

Fixes codegen when a operation introduced conflcts with a existing request shape. i.e

Operation -> OperationRequest

if a operation literally named OperationRequest is introduced there is a namespace conflict. this fixes that.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
sbiscigl marked this pull request as ready for review November 11, 2026 18:55
@sbiscigl
sbiscigl force-pushed the qualify-request-type-name-clash branch from b0dba7b to b32a852 Compare November 11, 2026 21:46
@sbiscigl
sbiscigl force-pushed the qualify-request-type-name-clash branch from b32a852 to e5de7e5 Compare November 12, 2026 14:38
@sbiscigl
sbiscigl added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit e0bfd88 Nov 12, 2026
6 checks passed
@sbiscigl
sbiscigl deleted the qualify-request-type-name-clash branch November 12, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants