Repository navigation
Conversation
…tions - ClientConfiguration keeps only settings every service shares; the 12 service-specific options move to generated per-service configurations, chosen from each service's endpoint rules and model (ServiceModel.getSupportedClientOptions) - Clients can no longer be built from the shared ClientConfiguration; an explicit XClientConfiguration(const ClientConfiguration&) seeds a service config from shared settings - Remove legacy client constructors and OverrideEndpoint (S3Crt unchanged until it becomes an alias of S3Client)
…r-client configuration Generated output of the previous commit's generator and template changes for these services.
- Regenerate all 438 service clients: each gets its own ClientConfiguration type with only the options its service supports; legacy constructors and OverrideEndpoint removed - KMSEncryptionMaterials takes KMSClientConfiguration - Update tests to build clients from their service's configuration
- The smoke-test generator wrote clientConfiguration.useFIPS/useDualStack for every service; services without dual-stack endpoints no longer have useDualStack, so those smoke tests failed to compile. Emit each line only when the value is true (false is the default), and update the committed smoke tests to match - Docs: useDualStack is on service configurations, not the shared ClientConfiguration
Conflicts: release/1.12 added executor tagging to the user agent next to the account ID endpoint mode method this branch added; kept both. UserAgent's constructor keeps the executor tagging, and the account ID endpoint mode is set through SetAccountIdEndpointMode since that field left ClientConfiguration.
- Regenerate the 11 protocol-test clients: each gets its own ClientConfiguration type; legacy constructors and OverrideEndpoint removed - Protocol tests build each client from its own configuration, seeded from the shared mock configuration (ProtocolTestsTestSuiteSrc.vm, AwsProtocolTestHelpers.h) - Also picks up the rest-xml-protocol serializer change from #3965 (ConvertToCompactString), which had not been regenerated for the test client
…guration S3PerformanceTest and DynamoDBPerformanceTest took the shared ClientConfiguration, which can no longer construct a service client; take S3ClientConfiguration and DynamoDBClientConfiguration instead. Fixes the AL2OnEC2CustomMemoryDefaultBuild step, the first CI build that enables BUILD_PERFORMANCE_TESTS.
…missing name BuiltInParameters::GetParameter() returns a function-local static for a missing name, which allocates on first use on libstdc++. Under CUSTOM_MEMORY_MANAGEMENT that allocation is tracked by the test memory system and reported as a leak (and freed after it is gone), failing AL2OnEC2CustomMemoryDefaultBuild. Check GetAllParameters() instead; the test asserts the same thing.
These tests change AWS_S3_USE_ARN_REGION / AWS_S3_DISABLE_MULTIREGION_ACCESS_POINTS mid-test. They used to build each client from the shared ClientConfiguration, which created a fresh S3ClientConfiguration (re-reading the environment) every time; they now reuse one S3ClientConfiguration created before the change. Set useArnRegion / disableMultiRegionAccessPoints on that config where the environment changes. Fixes TestCustomEndpointOverride, TestS3AccessPointARN and TestS3MultiRegionAccessPointARN; same fix in S3ControlTest.
averyk22
force-pushed
the
per-client-config-1.12
branch
from
November 13, 2026 15:34
84c91d7 to
e95feb2
Compare
release/1.12 lacks the dictionary entry main has, so cspell flags the existing AWS_USE_DUALSTACK_ENDPOINT names in ClientConfiguration.cpp.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Look at the first commit during review, second commit is all the generated files (too many of them)
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.