Skip to content

Announce when AVOCADO_RELEASEVER overrides the locked pin - #399

Open
jetm wants to merge 2 commits into
feed-ergo/offlinefrom
feed-ergo/release-override-notice
Open

jetm wants to merge 2 commits into
feed-ergo/offlinefrom
feed-ergo/release-override-notice

Conversation

@jetm

@jetm jetm commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

An exported AVOCADO_RELEASEVER silently beats the pin in avocado.lock, so a stale shell export or an inherited CI variable builds a different release than the lock records.

I print pin ignored: AVOCADO_RELEASEVER is set to <value>; the locked pin <pin> is not used once per run. avocado's own export and a value equal to the pin stay silent. The override still wins; see docs/releasever.md.

This PR is stacked on #398 (--offline), which it shares snapshot.rs with.

jetm added 2 commits November 13, 2026 17:51
An exported AVOCADO_RELEASEVER wins over the snapshot pin in
avocado.lock, silently. A user who exported it once in a shell, or a CI
job that inherits it, builds against a different release than the lock
file records and nothing on screen says so; the lock file reads as if
it was in force.

When the override is active and a pin applies to this config, avocado
now prints "pin ignored: AVOCADO_RELEASEVER is set to <value>; the
locked pin <pin> is not used", once per run. The override still wins.
avocado exports the variable itself after resolving a pin, and the
exporter and every later reader share the process, so the value it last
exported is recorded and a match is not reported as a user override.
A value equal to the pin is not reported either, since nothing is
ignored.

Signed-off-by: Javier Tia <javier@peridio.com>
The new "pin ignored" line names AVOCADO_RELEASEVER but not why it
appears, when it stays quiet, or how to make it go away. A user who
sees it in CI logs has no page that says the override still wins and
the notice changes nothing about the build.

docs/releasever.md states that the override always wins, shows the
line, lists the cases that stay silent (avocado's own export, a value
equal to the pin, no locked pin, the other release knobs), and says to
unset the variable to put the pin back in force. The CHANGELOG entry
points at it.

Signed-off-by: Javier Tia <javier@peridio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant