Repository navigation
Conversation
An exported AVOCADO_RELEASEVER wins over the snapshot pin in avocado.lock, silently. A user who exported it once in a shell, or a CI job that inherits it, builds against a different release than the lock file records and nothing on screen says so; the lock file reads as if it was in force. When the override is active and a pin applies to this config, avocado now prints "pin ignored: AVOCADO_RELEASEVER is set to <value>; the locked pin <pin> is not used", once per run. The override still wins. avocado exports the variable itself after resolving a pin, and the exporter and every later reader share the process, so the value it last exported is recorded and a match is not reported as a user override. A value equal to the pin is not reported either, since nothing is ignored. Signed-off-by: Javier Tia <javier@peridio.com>
The new "pin ignored" line names AVOCADO_RELEASEVER but not why it appears, when it stays quiet, or how to make it go away. A user who sees it in CI logs has no page that says the override still wins and the notice changes nothing about the build. docs/releasever.md states that the override always wins, shows the line, lists the cases that stay silent (avocado's own export, a value equal to the pin, no locked pin, the other release knobs), and says to unset the variable to put the pin back in force. The CHANGELOG entry points at it. Signed-off-by: Javier Tia <javier@peridio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exported
AVOCADO_RELEASEVERsilently beats the pin inavocado.lock, so a stale shell export or an inherited CI variable builds a different release than the lock records.I print
pin ignored: AVOCADO_RELEASEVER is set to <value>; the locked pin <pin> is not usedonce per run. avocado's own export and a value equal to the pin stay silent. The override still wins; seedocs/releasever.md.This PR is stacked on #398 (
--offline), which it sharessnapshot.rswith.