Repository navigation
Conversation
ScrollDirection only defined UP and DOWN, so scroll_till_visible could not scroll a horizontal list, although the Flutter integration server accepts 'left' and 'right' as scrollDirection (AxisDirectionEnumMap in appium-flutter-server's scroll_till_visible model). Add the LEFT and RIGHT members. The default stays DOWN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ScrollDirectiononly definesUPandDOWN, soFlutterCommand.scroll_till_visiblecannot scroll a horizontal list or carousel. Passing a string instead fails on the client:The Flutter integration server supports all four directions. appium-flutter-server's
scroll_till_visiblemodel mapsAxisDirection.up/right/down/leftto'up','right','down'and'left'. The driver's WebdriverIO service typesscrollDirectionas'up' | 'right' | 'down' | 'left'.Fix
Add
ScrollDirection.LEFT = 'left'andScrollDirection.RIGHT = 'right', and update the docstring, which said "up or down". The default staysDOWN, so existing calls are unchanged.Tests
LEFTandRIGHTare sent as'left'and'right'. It fails without the fix withAttributeError: type object 'ScrollDirection' has no attribute 'LEFT'.ruff check,ruff format --check,mypy appiumand the full unit test suite pass.🤖 Generated with Claude Code