Repository navigation
test: re-enable Android LogEventTest - #2485
Open
Ganesh2325 wants to merge 1 commit into
Open
Ganesh2325 wants to merge 1 commit into
Ganesh2325 wants to merge 1 commit into
Conversation
Ganesh2325
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
October 29, 2026 17:06
|
|
Event timestamps are Unix epoch millis, so intValue() overflows and the assertion fails even when the custom event was logged. Compare with longValue() and stop excluding the class. Part of appium#325
cursor
Bot
force-pushed
the
cursor/reenable-log-event-test-acdc
branch
from
October 30, 2026 09:16
7754d2b to
ce11e05
Compare
Author
|
/easycla |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #325
Change list
LogEventTest.verifyLoggingCustomEvents: compare the event timestamp withlongValue()instead ofintValue().LogEventTestfrom thee2eAndroidTestexclude list inbuild.gradle.Types of changes
Details
Appium returns event timestamps as epoch milliseconds (e.g.
1793292090478). Read as a 32-bit int that becomes-2004239250, so the> 0assertion failed even though the event was logged correctly.Verified on an API 28 emulator (same as CI) with Appium 4.0.0-beta.6 and UiAutomator2 9.0.0-beta.2:
./gradlew :e2eAndroidTest --tests io.appium.java_client.android.LogEventTestpassed on two clean runs; unit tests and checkstyle pass.This change was AI-assisted; I reviewed and tested it myself.