Repository navigation
fix: default logcat broadcast to the connected Appium server - #2484
Open
Ganesh2325 wants to merge 1 commit into
Open
Ganesh2325 wants to merge 1 commit into
Ganesh2325 wants to merge 1 commit into
Conversation
Ganesh2325
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
October 29, 2026 17:06
|
|
Contributor
|
@Ganesh2325 Could you please sign CLA? |
startLogcatBroadcast() hardcoded 127.0.0.1:4723, so a remote server or another port never reached the logcat socket. The no-arg method now uses the command executor URL. https becomes wss, and an HTTP base path such as /wd/hub is not added because Appium serves the socket at the server root. The host and host/port overloads stay compatible.
cursor
Bot
force-pushed
the
cursor/logcat-broadcast-server-url-2d6f
branch
from
October 30, 2026 09:15
d32ffa7 to
c9dd42c
Compare
Author
|
@mykola-mokhnach Thanks! I've signed the CLA. I'm also updating the commit authorship so the check picks it up; it should go green shortly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1352
Change list
startLogcatBroadcast()now uses the Appium server URL the driver is connected to (from the command executor) instead of the hardcoded127.0.0.1:4723.https/wssservers map towss; a missing port is left off the socket URI./wd/hub) is intentionally not appended, because the server registers/ws/session/<id>/appium/device/logcatat the root.Types of changes
Details
Added
ListensToLogcatMessagesTest(10 unit tests using a scripted HTTP client, no device needed)../gradlew test checkstyleMain checkstyleTest javadocpasses.This change was AI-assisted; I reviewed and tested it myself.