Repository navigation
test: poll for dataset items in scrapy E2E tests - #1225
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
+ Coverage 93.46% 93.81% +0.34%
==========================================
Files 54 54
Lines 3797 3799 +2
==========================================
+ Hits 3549 3564 +15
+ Misses 248 235 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
November 3, 2026 22:08
apify-factory
approved these changes
Nov 3, 2026
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Apify Factory auto approved ✅ — the strict one and the suspicious one both nodded
Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.
Approval locked to 0087914f4 · workflow run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_cb_kwargs_spiderfailed on an E2E run withMissing product: Widget A. The run succeeded and the API reported 3 items in the dataset, but the items page it returned was empty. The test read the dataset right after the run finished, before the pushed items were readable.verify_spider_resultsnow pollslist_items()withpoll_until_conditionuntil the expected items show up, for up to 30 s. The assertions are unchanged, and every scrapy spider test that uses the helper gets the fix.✍️ Drafted by Claude Code