Skip to content

test: poll for dataset items in scrapy E2E tests - #1225

Merged
vdusek merged 3 commits into
masterfrom
fix/scrapy-e2e-dataset-read-lag
Nov 4, 2026
Merged

vdusek merged 3 commits into
masterfrom
fix/scrapy-e2e-dataset-read-lag

Conversation

@vdusek

@vdusek vdusek commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

test_cb_kwargs_spider failed on an E2E run with Missing product: Widget A. The run succeeded and the API reported 3 items in the dataset, but the items page it returned was empty. The test read the dataset right after the run finished, before the pushed items were readable.

verify_spider_results now polls list_items() with poll_until_condition until the expected items show up, for up to 30 s. The assertions are unchanged, and every scrapy spider test that uses the helper gets the fix.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 3, 2026
@vdusek vdusek self-assigned this Nov 3, 2026
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (aab5cf8) to head (0087914).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   93.46%   93.81%   +0.34%     
==========================================
  Files          54       54              
  Lines        3797     3799       +2     
==========================================
+ Hits         3549     3564      +15     
+ Misses        248      235      -13     
Flag Coverage Δ
e2e 31.48% <ø> (-0.02%) ⬇️
integration 51.38% <ø> (-0.03%) ⬇️
unit 90.99% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested a review from apify-factory November 3, 2026 22:08
@vdusek
vdusek marked this pull request as ready for review November 3, 2026 22:08
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 3, 2026

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Apify Factory auto approved ✅ — the strict one and the suspicious one both nodded

Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.

Approval locked to 0087914f4 · workflow run

@vdusek
vdusek merged commit da614f7 into master Nov 4, 2026
42 of 43 checks passed
@vdusek
vdusek deleted the fix/scrapy-e2e-dataset-read-lag branch November 4, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants