Repository navigation
[Relax][ONNX] Fix default direction attribute decoding in BitShift - #20963
Open
Chaitanya140904 wants to merge 1 commit into
Open
Chaitanya140904 wants to merge 1 commit into
Chaitanya140904 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an
AttributeErrorwhen decoding thedirectionattribute in theBitShiftRelax ONNX operator converter.Summary
Previously,
BitShift._impl_v11attempted to decode the direction attribute viaattr.get("direction", "LEFT").decode("ascii"). Whendirectionwas omitted or defaulted to the string"LEFT", calling.decode("ascii")on astrraisedAttributeError: 'str' object has no attribute 'decode'.This change checks
isinstance(direction, bytes)before calling.decode("ascii"), ensuring safe decoding whether the attribute is provided asbytesorstr. It also adds unit tests coveringBitShiftwithLEFT,RIGHT, multiple integer bit widths, and the default fallback whendirectionis omitted.Closes #20950