Repository navigation
Fix FMPP xml-resolver resolution with local metadata - #1103
Open
hongzhi-gao wants to merge 1 commit into
Open
hongzhi-gao wants to merge 1 commit into
hongzhi-gao wants to merge 1 commit into
Conversation
Contributor
Author
|
@ColinLeeo PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMPP transitively declares
xml-resolver:[1.1,). With Maven 3.10.0, a local metadata file listing version 1.2 can cause that version to be resolved as a local installation, even when its JAR is only registered as a remote download. Plugin resolution then fails withverifying that is downloadable from []/Could not find artifact xml-resolver:xml-resolver:jar:1.2.Pin
xml-resolver:1.2as a direct dependency ofdrill-fmpp-maven-plugin. This retains the currently selected artifact version and affects build tooling only; runtime dependencies and generated code are unchanged.Related to #1084 and Jenkins develop build #600. The failure was reproduced locally at the same revision (
b16df6b0); the Jenkins node's cache has not been inspected.Validation used Maven 3.10.0, JDK 17, empty user settings, and an isolated local repository. The repository contained a Central-downloaded
xml-resolver:1.2JAR plusmaven-metadata-local.xmllisting 1.2:mvn -P with-java -pl java/tsfile -am clean test-compile -DskipTests: unpatched fails with the same empty-repository error; patched passes with the same cache.mvn -P with-java -pl java/tsfile -am test -Dtest=FilterSerializeTest,StatisticsFilterTest -Dsurefire.failIfNoSpecifiedTests=false: 26 tests passed, none skipped.git diff --checkpassed.The full Java test suite and a Jenkins rerun were not executed.