Repository navigation
Decode HPACK Huffman string literals a byte at a time - #1255
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
Replace the bit-at-a-time tree walk with a table indexed by eight bits of input, as other HPACK implementations do. Decoding is about three times faster with identical results, including the three decoding errors required by RFC 7541, section 5.2. Add tests for the Huffman encoded literals in the RFC 7541 examples and for the decoding errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPackHuffman.decodewalks the code tree one bit at a time. Profiling Tomcat under HTTP/2 load with the JDKHttpClient(which sends header values as Huffman literals on every request rather than indexing them) showed about 26% of server CPU in this method.This replaces the tree walk with a table indexed by eight bits of input, as other HPACK implementations do.
:pathvalues about 2x).:pathis Huffman decoded per request, so there is no measurable end-to-end difference.Added tests for the Huffman literals in the RFC 7541 appendix C examples and for the decoding errors. The HTTP/2 tests and the smoke profile pass.