Repository navigation
Register the Param tag plugin in the sample tagPlugins.xml - #1254
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
The Import plugin generates the parameters in its body through the Param plugin. The sample configuration did not register Param, so the standard <c:param> handler ran inside the inlined <c:import>, found no enclosing import handler and failed with a JspTagException (HTTP 500). Test the Import plugin with the sample configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the sample
tagPlugins.xml(the onejasper-howtopoints to), any<c:import>or<c:url>with a nested<c:param>fails with HTTP 500:JspTagException: <param> outside <import>.The Import plugin generates its parameters through the Param plugin, but the sample does not register Param, so the standard
<c:param>handler runs inside the inlined<c:import>and finds no enclosing import handler.TestImportnow uses the sample configuration (it used its own file that already registered Param, which is why this was not caught), and that file is removed. Without the fixtestParamsandtestParamKeepsUserAttributereturn 500.Checked on a running Tomcat against JSTL 3.0.1: with the fix the plugin output matches the standard tags.