Skip to content

refactor(agent-service): drop unused state and helper methods - #9239

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/agent-dead-state-helpers
Open

aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/agent-dead-state-helpers

Conversation

@aglinxinyuan

@aglinxinyuan aglinxinyuan commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Removes obsolete validation state management and unused helper methods in agent-service:

  • WorkflowState:
    • Drops internal validation state tracking (validationErrors, workflowEmpty, validationChangedSubject) and associated methods (getValidationChangedStream, getValidationOutput, setValidationError, clearValidationError, setAllValidationErrors, updateWorkflowEmptyState, emitValidationChanged). Property validation is handled directly by WorkflowSystemMetadata.validateOperatorProperties during tool execution.
    • Drops unused updateOperatorInputPorts, getLink, and getFrontierOperators.
  • TexeraAgent:
    • Drops unused helper getStepsById().
  • WorkflowSystemMetadata:
    • Drops unused helper methods getAllSchemasAsJson() and operatorTypeExists(), along with private interface OperatorSchemaInfo.
  • types/workflow.ts:
    • Drops unused OperatorDetail interface.
  • WorkflowResultState:
    • Drops unused helper method getOperatorInfo().

Any related issues, documentation, discussions?

Closes #9238

How was this PR tested?

Tested with Bun test runner in agent-service:

cd agent-service
bun test

Output:

313 pass
0 fail
765 expect() calls
Ran 313 tests across 19 files. [2.10s]

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Antigravity 2.0

Copilot AI balanced review requested due to automatic review settings October 31, 2026 01:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions github-actions Bot added the refactor Refactor the code label Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @yangzhang75, @bobbai00, @roshiiiz
    You can notify them by mentioning @yangzhang75, @bobbai00, @roshiiiz in a comment.

@aglinxinyuan
aglinxinyuan requested a review from kunwp1 October 31, 2026 01:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-service refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop unused WorkflowState validation cluster and helper methods in agent-service

2 participants