Repository navigation
Bump dependencies to fix security alerts - #846
Merged
Merged
Conversation
- junit:junit 4.12 -> 4.13.2 (root pom, test scope), CVE-2020-15250 - org.apache.logging.log4j:log4j-core/log4j-api 2.8.1 -> 2.25.5 (test/plugin tooling), CVE-2021-44228, CVE-2021-45046 and others - mysql:mysql-connector-java 8.0.13 -> 8.0.33 (mysql-common, test scope) Provided-scope plugin dependencies are compile-only compatibility targets and are left unchanged.
- actions/checkout v2 -> v7, actions/setup-java v2 -> v6, actions/upload-artifact v4 -> v7, actions/download-artifact v4 -> v8, actions/cache v4 -> v6, github/codeql-action v3 -> v4 - docker/login-action v4.6.0 -> v4.7.0 (v4.6.0 is deprecated in the ASF allow list) - apache/skywalking-eyes 2021 commits -> v0.9.0; ignore dist-material/licenses in .licenserc.yaml, which v0.9.0 no longer matches through the 'licenses' pattern
kezhenxu94
approved these changes
Nov 2, 2026
wu-sheng
requested review from
wankai123
and removed request for
ascrutae and
peng-yongsheng
November 2, 2026 09:21
wankai123
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump dependencies to fix security alerts
This PR only touches dependencies that are not
providedscope: test-scope dependencies and the plugin test tooling. It also moves GitHub Actions to the versions the ASF currently approves.Dependencies
junit:junitpom.xmlorg.apache.logging.log4j:log4j-core(andlog4j-apito match)test/plugin/pom.xmlmysql:mysql-connector-javaapm-sniffer/apm-sdk-plugin/mysql-common/pom.xmlNotes:
apm-test-tools,httpClient-4.x-plugin,httpclient-5.x-plugin,websphere-liberty-23.x-pluginandsolon-2.x-pluginset their ownjunit.version=4.12, so they keep 4.12. Dependabot has no alerts on those manifests, andapm-test-toolsdeclares junit asprovided.mysql:mysql-connector-java:8.0.33is a relocation POM tocom.mysql:mysql-connector-j:8.0.33. GHSA-m6vm-37g8-gqvh / CVE-2023-22102 (<= 8.0.33) stays open, because no release under the old coordinates fixes it. Themysql-commontests do not import any MySQL driver class.GitHub Actions
actions/*,github/*andapache/*are allowed by the ASF policy, so they keep the repo's tag style. Third-party actions are pinned by SHA fromapache/infrastructure-actionsactions.yml.actions/checkoutv2 -> v7actions/setup-javav2 -> v6actions/upload-artifactv4 -> v7actions/download-artifactv4 -> v8. Every download is byname, so the v5 download-by-ID path change does not apply.actions/cachev4 -> v6github/codeql-action/initandanalyzev3 -> v4docker/login-actiondbcb8138…(v4.6.0, deprecated in the ASF list, expires 2027-01-16) ->81c6f93d4bc991e510b342a00b419b3bb4efc5c6(v4.7.0)apache/skywalking-eyes9bd5feb8…(ci.yaml) anda63f4afc…(.github/actions/build), both commits from 2021 ->a196742f472feaffafea537ce5a2a4c3c53a8de4(v0.9.0). v0.9.0 no longer treats thelicensesignore entry as matchingdist-material/licenses/LICENSE-asm.txt, so.licenserc.yamlnow also ignoresdist-material/licenses.docker/setup-qemu-actionv4.4.0,docker/setup-buildx-actionv4.4.1,apache/skywalking-infra-e2e56ac8befeb5f910f2dc9339e65d07cd18953f90e.E2E on Docker 29 / ubuntu-26.04: infra-e2e is already pinned to
56ac8bef…. The plugin-test run action already turns off the containerd image store. No workflow calls thedocker-composev1 binary, and no workflow pins a removed runner image. E2E onmainis green, and this PR's CI covers it.Verified locally
JAVA_HOME=<jdk8> ./mvnw -B -f test/plugin/pom.xml -Dmaven.test.skip -pl runner-helper,agent-test-tools -am clean package: BUILD SUCCESS, with log4j 2.25.5 shaded intoplugin-runner-helper.jar. I then ran that jar againstmysql-scenarioand it generatedscenario.shanddocker-compose.yml. Thecontainersmodule builds Docker images and was not run.JAVA_HOME=<jdk17> ./mvnw -B -Dmaven.gitcommitid.skip=true -pl apm-commons/apm-util,apm-commons/apm-datacarrier,apm-sniffer/apm-agent-core,apm-sniffer/apm-sdk-plugin/mysql-common -am clean verify: BUILD SUCCESS, all tests pass on JUnit 4.13.2, and checkstyle passes. The git-commit-id skip is needed only because the local checkout is a git worktree.dependency:list: junit resolves to 4.13.2 (test) in the modules that inherit it, and to 4.12 (provided) inapm-test-tools.mysql-commonresolvescom.mysql:mysql-connector-j:8.0.33(test).license-eye header checkbuilt from skywalking-eyes v0.9.0 passes with the updated.licenserc.yaml: 0 invalid files.Deliberately left unchanged
<scope>provided</scope>plugin and toolkit dependency, for example struts2, dubbo, spring-webflux, log4j 1.x/2.x toolkit, kafka, mysql 5.x/6.x/8.x plugins and okhttp. These are compile-only compatibility targets, so their alerts are false positives.apm-toolkit-micrometer-registry/apm-toolkit-micrometer-1.10micrometer-core(GHSA-g3pr-3p32-fp23): this is compile scope, but it is the API baseline the toolkit builds against. The vulnerable lines (<= 1.9.17,1.10.0-1.13.15) have no patched release, and the CVE is in micrometer's HTTP server instrumentations, which the toolkit does not use.motan-pluginspring-context4.2.4.RELEASE (test scope): the only fix on the 5.x line is 5.2.21 (a new major), and two of the three alerts have no fix before Spring 6, which needs Java 17.jdbc-commonsmysql-connector-java[2.0.14,6.0.6](test scope): this is a deliberate range, and the tests usecom.mysql.cj.api.jdbc.JdbcConnection, which exists only in 6.0.x. The fixes need 8.0.28 or later.test/plugin/scenarios/**framework pins.This PR is expected to close 13 of the 262 open Dependabot alerts: #1, #17, #23, #24, #406, #958, #1513, #1615, #2058, #2098, #79, #257 and #262.
CHANGESlog. (Not updated: only test and CI dependencies change, and nothing shipped changes.)