Repository navigation
Conversation
The templates now remove tags, decode entities and encode the result, so the attribute is encoded exactly once in both modes. MetaDescriptionEscapingTest renders both templates with stored and pre-encoded values; it fails on the old templates. (cherry picked from commit f9b195e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #253 to 6.1.x: encode meta descriptions once, whatever the trust setting.
#showMetaDescriptioninweblog.vmand Gaurav'sstd_head.vmprint the description with tags removed, entities decoded, then encoded.-x; onlyCHANGES.mdneeded resolving, under a new 6.1.8 section.MetaDescriptionEscapingTestcomes with it and passes on 6.1.x.mvn -pl app test: 498 tests, 0 failures.Master already has this change, so nothing goes back.