[snoopdave]

A custom page reads tags= from the query string. Three rough edges:

• With entry= also present, the tags weren't checked against the weblog, because the check sat in the last branch of the validation chain. They are now checked whenever they're given; unknown tags answer 404, as they already did without an entry.
• #showAutodiscoveryLinks printed the tag names into the feed link titles as is. They're now HTML-encoded there, and in the Gaurav and Fauxcoly tags_index.vm pages.
• The page cache keyed a custom page that names an entry by the entry alone, and left request tags out of custom-page keys. The key now includes the page name and the (sorted, encoded) tags.

Tests: AutodiscoveryLinksRenderingTest renders the real macro; WeblogPageCacheKeyTest covers the keys. Both fail on roller-6.1.x and pass here. No test covers the PageServlet change. mvn -pl app test: 503 tests, 0 failures.

Once this is merged, the same change goes to master for 7.0.0, where the Hyde, Terminal and PaperMod tag pages need the same encoding.

[mraible]

LGTM. Tags are now checked whenever they're given, so an entry plus unknown tags answers 404. The cache key now includes the page name and the URL-encoded tags. I checked the rest of 6.1.x, and every other place that prints the tags already encodes them. Optional: a test for the PageServlet change, which the description says isn't covered.