Repository navigation
Conversation
The Design menu is shown only while themes.customtheme.allowed is on, but the theme, stylesheet and template actions behind it did not check that setting. They now return it from isFeatureEnabled(), so the security interceptor treats them like the menu does. The XML-RPC blogger.setTemplate call checks the same setting. Weblogs that already use custom templates keep rendering them.
mraible
approved these changes
Nov 15, 2026
mraible
left a comment
mraible
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The four Design actions now follow themes.customtheme.allowed the same way the menu does, and on 6.1.x these are all of the Design actions. The blogger.setTemplate check runs after authentication and before anything is saved. For the master port: the XML-RPC rewrite in #263 kept BloggerAPIHandler, so the same change should apply there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Design menu (theme, stylesheet and templates) is shown only while
themes.customtheme.allowedis on, but the actions behind it didn't check that setting.ThemeEdit,Templates,TemplateEditandStylesheetEditreturn the setting fromisFeatureEnabled(), soUISecurityInterceptortreats them the way the menu does.Templatesalso covers its add/remove subactions.blogger.setTemplatecall checks the same setting.getTemplateis unchanged.Tests:
DesignPagesFeatureTestchecks the four actions with the setting on and off.XMLRPCWeblogPermissionTestturns the setting on for its existing checks and adds one forsetTemplatewith it off. Both fail onroller-6.1.xand pass here.mvn -pl app test: 500 tests, 0 failures.Once this is merged, the same change goes to master for 7.0.0.