Repository navigation
Conversation
With webservices.enableXmlRpc off, every weblog whose client support was on still linked to its RSD document from #showAutodiscoveryLinks, and the RSD still listed the Blogger and MetaWeblog endpoints, which then answered 404 "XML-RPC service is disabled". Found while testing 7.0 on a copy of raibledesigns.com. ConfigModel gains getXmlRpcEnabled(), and the macro links to the RSD only when that and the weblog's enableBloggerApi are both true. RSDServlet answers 404 unless both are true, since there is nothing else to describe. XmlRpcEnabledFilter logs each refused request at debug instead of WARN, as the AtomPub servlet does. RSDServletTest checks the servlet's condition for each combination and renders the macro through Velocity; the template case fails on master.
snoopdave
approved these changes
Nov 15, 2026
snoopdave
left a comment
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
PR-Review: no issues. Both the EditURI link and the RSD servlet are gated, and the check runs before the 304 path. Minor: RSDServletTest loads templates from a path relative to the working directory; using project.basedir as ThemeAssetReferencesTest in #266 does would let it run from an IDE too.
RSDServletTest loaded Velocity templates from a path relative to the working directory, so it only ran from app/. It now resolves them from project.basedir, falling back to the working directory, as ThemeAssetReferencesTest does.
The previous commit read project.basedir, but neither Surefire nor an IDE sets that property, so it always fell back to the working directory. The module directory now comes from where the test class was compiled to, which doesn't depend on the working directory.
Contributor
Author
|
Done. I copied #266's approach at first in 896b169, but neither Surefire nor an IDE sets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing 7.0 on a copy of raibledesigns.com.
With
webservices.enableXmlRpcoff, every weblog with client support turned on still:#showAutodiscoveryLinks,<link rel="EditURI">);XmlRpcEnabledFilteralso logged a WARN for every one of those refused calls.The fix:
ConfigModel.getXmlRpcEnabled()exposes the site setting to templates.$weblog.enableBloggerApi && $config.xmlRpcEnabled.RSDServletanswers 404 unless both are on, since the RSD only describes that endpoint.XmlRpcEnabledFilterlogs refused requests at debug, as the AtomPub servlet does.RSDServletTestchecks the servlet's condition for each combination of site and weblog setting, and renders the macro through Velocity. The template case fails on master.