Repository navigation
[ISSUE #11519] Fix early return in updateAndCreateTopicList when batch contains unchanged topics - #11520
Open
apkipa wants to merge 1 commit into
Open
[ISSUE #11519] Fix early return in updateAndCreateTopicList when batch contains unchanged topics#11520apkipa wants to merge 1 commit into
apkipa wants to merge 1 commit into
Conversation
…n batch contains unchanged topics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
In
AdminBrokerProcessor#updateAndCreateTopicList, hitting an unchanged topic inside the validation loop previously executedreturn response;, exiting the entire batch request early and skipping all subsequent topics intopicConfigList.This PR skips unchanged topics with
continueand only updates/registers the changed subset (needUpdateTopicConfigList) when non-empty.How Did You Test This Change?
AdminBrokerProcessorTest#testUpdateAndCreateTopicListWithUnchangedTopicscovering all-unchanged batches and mixed batches ([unchanged, updated, new]) under both incremental andenableSingleTopicRegistermodes.mvn -pl broker -am test -Dtest=AdminBrokerProcessorTest -DfailIfNoTests=false.