Repository navigation
[ISSUE #11510] Add independent Fast Remoting and HA service switches - #11511
Open
qianye1001 wants to merge 3 commits into
Open
qianye1001 wants to merge 3 commits into
qianye1001 wants to merge 3 commits into
Conversation
lizhimins
previously approved these changes
Nov 12, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #11511 +/- ##
=============================================
- Coverage 49.79% 49.76% -0.03%
+ Complexity 14407 14403 -4
=============================================
Files 1391 1391
Lines 103381 103408 +27
Branches 13529 13548 +19
=============================================
- Hits 51477 51465 -12
- Misses 45686 45706 +20
- Partials 6218 6237 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lizhimins
reviewed
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Standalone deployments currently cannot disable the Fast Remoting server or the HA service independently. Add two startup options to
BrokerConfig, both defaulting totrueto preserve existing behavior:enableFastRemotingServer=false: do not create the Fast server (listenPort - 2), and skip its processor registrations. Covers ordinary brokers and per-broker sub-servers in BrokerContainer.enableHAService=false: do not create or initialize an HA service. This stops the entire service: the HA listener, outbound replication client, GroupTransferService and HAConnectionStateNotificationService are not started. The store lifecycle safely handles an absent HA service.Disabling HA requires ASYNC_MASTER without controller or slave-acting-master mode. Incompatible configurations fail at the beginning of the store constructor before storage resources are initialized, instead of running replication-dependent modes without an HA service. Existing duplication and DLedger semantics are unchanged; this option does not disable alternative replication implementations.
Both options require a broker restart. Clients must use the main endpoint when Fast Remoting is disabled. BrokerContainer's own management listeners are unchanged. No reflection or changes to replication-mode flags are used.
How Did You Test This Change?
BrokerControllerTest#testBrokerRestart,testCustomRemotingServer,testBrokerMetricsManagerInitialization;HATest#testHandleHA,testSemiSyncReplica(5 tests, no failures/errors).The external verification harnesses are not included in this PR.
CI follow-up
The first Bazel run built successfully and passed 608 of 609 test targets.
TlsTest#disabledServerRejectsSSLClientfailed because the TLS-disabled server closed the channel before the client checked its active state, producingRemotingConnectExceptionrather thanRemotingSendRequestException. The test and production Remoting implementation were identical to the base branch.Update that existing test to accept both rejection timings; a successful request still fails the assertion. No production behavior changes are included in this follow-up. The complete 13-test TLS suite passes on Linux JDK 8, along with Checkstyle and SpotBugs. The affected rejection test also passes 30 consecutive runs on Linux JDK 8. A fresh PR CI run has been triggered and is waiting for a runner.