Repository navigation
Conversation
`getEventTimestamp` returns 0 both when the producer set no event time and when it explicitly set the Unix epoch. Add `hasEventTimestamp`, mirroring the existing `hasPartitionKey`/`hasOrderingKey`, so callers can tell the two apart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Message::getEventTimestampreturns 0 both when the producer set no event time and when it set the Unix epoch, so a consumer cannot tell the two apart.hasPartitionKeyandhasOrderingKeyalready exist for the same reason.Modifications
Add
Message::hasEventTimestamp, which returns whether the message metadata hasevent_time.Verifying this change
This change added tests and can be verified as follows:
MessageTest.testHasEventTimestamp: a message without an event time, with an event time of 0 and with a non-zero one.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
The new method is documented in
Message.h.This fix comes from the fork of this repository that ClickHouse uses for its Pulsar table engine (ClickHouse/ClickHouse#64184).
🤖 Generated with Claude Code