Skip to content

[improve][client] Do not log the addresses of connection objects in ConnectionPool #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groeneai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[improve][client] Do not log the addresses of connection objects in ConnectionPool #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/ConnectionPool.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,12 @@ Future<Error, ClientConnectionWeakPtr> ConnectionPool::getConnectionAsync(const

if (!cnx->isClosed()) {
// Found a valid or pending connection in the pool
LOG_DEBUG("Got connection from pool for " << key << " use_count: " //
<< (cnx.use_count()) << " @ " << cnx.get());
LOG_DEBUG("Got connection from pool for " << key << " use_count: " << (cnx.use_count()));
return cnx->getConnectFuture();
} else {
// The closed connection should have been removed from the pool in ClientConnection::close
LOG_WARN("Deleting stale connection from pool for " << key << " use_count: " << (cnx.use_count())
<< " @ " << cnx.get());
LOG_WARN("Deleting stale connection from pool for " << key
<< " use_count: " << (cnx.use_count()));
pool_.erase(key);
}
}
Expand Down